-
-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: changed user-agent, more logging, removed infinite loop #883
Merged
braindigitalis
merged 20 commits into
brainboxdotcc:dev
from
Jaskowicz1:sslclient-changes
Sep 25, 2023
Merged
refactor: changed user-agent, more logging, removed infinite loop #883
braindigitalis
merged 20 commits into
brainboxdotcc:dev
from
Jaskowicz1:sslclient-changes
Sep 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dpp-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Mishura4
previously requested changes
Sep 23, 2023
braindigitalis
requested changes
Sep 23, 2023
Patch/jaskowicz1/sslclient changes
Co-authored-by: Neko-Life <[email protected]>
github-actions
bot
added
the
documentation
Improvements or additions to documentation
label
Sep 24, 2023
braindigitalis
requested changes
Sep 24, 2023
braindigitalis
requested changes
Sep 24, 2023
Commandserver
removed
the
documentation
Improvements or additions to documentation
label
Sep 24, 2023
github-actions
bot
added
the
documentation
Improvements or additions to documentation
label
Sep 25, 2023
braindigitalis
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the user-agent in wsclient (to match versions.h, sorta), adds more logging in sslclient.cpp, and removes an infinite loop in
discord_voice_client::thread_run
.The logging in sslclient.cpp will now send a warning when we encounter a HTTP code that isn't 204, 101, or 200. This means people can see what's going on and report it, without modifying D++ which is very helpful the more we move towards getting people to use pre-compiled binaries (view the image above the checklist for a preview).
The infinite loop in
discord_voice_client::thread_run
was caused by the error code 400 (you can view #714 for more info). Whilst we haven't fix the issue that #714 is about, we now tell users what's going on if things start to break (as mentioned above). The infinite loop simply checks how many times thedo while
loop has ran, if it's ran 5 times (without a 3 second break inbetween a loop) then we break the loop. This will mean we also don't spam the console too much with the above addition.Code change checklist