docs: fixed a ref issue and added more info in discordvoiceclient.h #871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dpp-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
braindigitalis
approved these changes
Sep 20, 2023
Neko-Life
reviewed
Sep 20, 2023
| * | ||
| * @param audio_data Raw PCM audio data. Channels are interleaved, | ||
| * with each channel's amplitude being a 16 bit value. | ||
| * | ||
| * The audio data should be 48000Hz signed 16 bit audio. | ||
| * @warning **The audio data needs to be 48000Hz signed 16 bit audio, otherwise, the audio will come through incorrectly!** |
There was a problem hiding this comment.
You might want to replace "incorrectly" with a more explanatory term. Having a mismatched sample rate can alter the pitch and tempo of the audio playback. Specifically, a lower sample rate can result in a higher pitch and faster tempo, while a higher sample rate can produce the opposite effect
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
discordvoiceclient.h was not referencing
dpp::cluster::on_voice_buffer_sendcorrectly, this has been altered. I've also changed the notice ofthe audio data needs to be...to be a warning, to which it also states that the audio will be affected if it isn't at that hz (just to inform people what will happen otherwise).Documentation change checklist
doxygen, and testing examples).