Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fixed mistakes, removed [&] #859

Merged
merged 25 commits into from
Sep 16, 2023
Merged

docs: fixed mistakes, removed [&] #859

merged 25 commits into from
Sep 16, 2023

Conversation

Henonicks
Copy link
Contributor

I see some examples use [&] and the advanced reference says that it's better not to use it. So I don't think we should do it in the examples. Also, there were punctuation mistakes in those files, fixed those.

  • My pull request is made against the dev branch.
  • I have ensured that the changed library can be built on your target system. I did not introduce any platform-specific code.
  • I have ensured that all methods and functions are fully documented using doxygen style comments.
  • I tested my commits, by adding a test case to the unit tests if needed
  • I have ensured that I did not break any existing API calls.
  • My code follows the coding style guide (if you are not sure, match the code style of existing files including indent style etc).
  • I have not built my pull request using AI, a static analysis tool or similar without any human oversight. Where I have generated this pull request using a tool, I have justified why this is needed.

Henonicks and others added 24 commits August 31, 2023 19:27
…sary stuff, matched the Coding Style Standards more accurately.
… code, renamed editing-objects.md into editing-channel-and-message.md (hopefully didn't miss anything)
@netlify
Copy link

netlify bot commented Sep 16, 2023

Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit cb2418b
🔍 Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/6505d697257b020007f36fa4
😎 Deploy Preview https://deploy-preview-859--dpp-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@Jaskowicz1 Jaskowicz1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one thing :)

@Jaskowicz1
Copy link
Contributor

I would advise that you move your future PRs into a separate branch. Your PRs are starting to contain many commits from old PRs (because you're merging them into your dev branch).

@Henonicks
Copy link
Contributor Author

But if I do so, some files will be missing and I'll request pull without needed/non-up-to-date files, no?

@ruslan-ilesik
Copy link
Contributor

you can create new branch which will be copy of current dev branch and use git cherry-pick (more detailed here)

@Jaskowicz1
Copy link
Contributor

But if I do so, some files will be missing and I'll request pull without needed/non-up-to-date files, no?

No. If you make your branch from dev, you'll be okay. Even if you don't, if you only commit your files, only they get seen by GitHub.

@Jaskowicz1
Copy link
Contributor

you can create new branch which will be copy of current dev branch and use git cherry-pick (more detailed here)

You don't need git cherry-pick. Just do git checkout -b branch-name dev

@Henonicks
Copy link
Contributor Author

Henonicks commented Sep 16, 2023

No. If you make your branch from dev, you'll be okay. Even if you don't, if you only commit your files, only they get seen by GitHub.

So if I copy it to my own branch and commit files that I need to only, I'll be fine and I won't have to keep pulling/re-cloning?

@Jaskowicz1
Copy link
Contributor

So if I copy it to my own branch and commit files that I need to only, I'll be fine and I won't have to keep pulling/re-cloning?

Exactly. This means you just do what you want on your branch and once the PR is merged, you delete the branch. You should still keep pulling dev though, to make sure that's up-to-date.

@Henonicks
Copy link
Contributor Author

Exactly. This means you just do what you want on your branch and once the PR is merged, you delete the branch. You should still keep pulling dev though, to make sure that's up-to-date.

So, I "copy" the branch, do stuff and when it's merged, delete it and do it over again?

@Jaskowicz1
Copy link
Contributor

Exactly. This means you just do what you want on your branch and once the PR is merged, you delete the branch. You should still keep pulling dev though, to make sure that's up-to-date.

So, I "copy" the branch, do stuff and when it's merged, delete it and do it over again?

Yup. If you feel like you need more information about this, I can look to make a tutorial for this.

@Henonicks
Copy link
Contributor Author

Yup. If you feel like you need more information about this, I can look to make a tutorial for this.

I guess I'll just keep on learning the power of Googling.

@raxyte raxyte added the documentation Improvements or additions to documentation label Sep 16, 2023
@Mishura4 Mishura4 changed the title [Docs]: fixed mistakes, removed [&] docs: fixed mistakes, removed [&] Sep 16, 2023
@Mishura4 Mishura4 merged commit 504afea into brainboxdotcc:dev Sep 16, 2023
29 checks passed
Mishura4 pushed a commit to Mishura4/DPP-PRs that referenced this pull request Sep 17, 2023
@Henonicks Henonicks deleted the dev branch September 18, 2023 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants