Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added [[maybe_unused]] in some places where it was needed #856

Merged
merged 1 commit into from
Sep 15, 2023

Conversation

1mi0
Copy link
Contributor

@1mi0 1mi0 commented Sep 15, 2023

  • [*] My pull request is made against the dev branch.
  • [*] I have ensured that the changed library can be built on your target system. I did not introduce any platform-specific code.
  • [*] I have ensured that all methods and functions are fully documented using doxygen style comments.
  • [*] I tested my commits, by adding a test case to the unit tests if needed
  • [*] I have ensured that I did not break any existing API calls.
  • [?] My code follows the coding style guide (if you are not sure, match the code style of existing files including indent style etc).
  • [*] I have not built my pull request using AI, a static analysis tool or similar without any human oversight. Where I have generated this pull request using a tool, I have justified why this is needed.

@CLAassistant
Copy link

CLAassistant commented Sep 15, 2023

CLA assistant check
All committers have signed the CLA.

@braindigitalis
Copy link
Contributor

thanks! please retarget this pr against the dev branch

include/dpp/json_interface.h Show resolved Hide resolved
include/dpp/json_interface.h Show resolved Hide resolved
@1mi0
Copy link
Contributor Author

1mi0 commented Sep 15, 2023

To answer all questions:
[[maybe_unused]] in our situation tells the compiler that we don't use the parameters inside of their functions. Not that we won't use them when we call the function or in other overloads | overrides of the function. In these specific 4 cases it just so happens that those arguments are not used inside of their lambda/function causing unused variable errors in my instance and warnings in other instances.

@1mi0 1mi0 changed the base branch from master to dev September 15, 2023 10:46
@braindigitalis braindigitalis merged commit ff7635c into brainboxdotcc:dev Sep 15, 2023
24 checks passed
Mishura4 pushed a commit to Mishura4/DPP-PRs that referenced this pull request Sep 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants