Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created get_url methods for message, channel and user. #855

Merged
merged 5 commits into from
Sep 15, 2023
Merged

Created get_url methods for message, channel and user. #855

merged 5 commits into from
Sep 15, 2023

Conversation

ruslan-ilesik
Copy link
Contributor

feat: allow get_url methods for message, channel and user or as (user_url , message_url, channel_url, thread_url) in dpp::utility namespace.

test: created unit tests for all this methods.

Introduced new constant to dpp::utility namespace, called url_host (in analogy to cdn_host)

  • My pull request is made against the dev branch.
  • I have ensured that the changed library can be built on your target system. I did not introduce any platform-specific code.
  • I have ensured that all methods and functions are fully documented using doxygen style comments.
  • I tested my commits, by adding a test case to the unit tests if needed
  • I have ensured that I did not break any existing API calls.
  • My code follows the coding style guide (if you are not sure, match the code style of existing files including indent style etc).
  • I have not built my pull request using AI, a static analysis tool or similar without any human oversight. Where I have generated this pull request using a tool, I have justified why this is needed.

@netlify
Copy link

netlify bot commented Sep 14, 2023

Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit ddb17ea
🔍 Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/65048198eedc2900084104b7
😎 Deploy Preview https://deploy-preview-855--dpp-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@CLAassistant
Copy link

CLAassistant commented Sep 14, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@Commandserver Commandserver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice too see this feature here!

src/dpp/utility.cpp Show resolved Hide resolved
src/dpp/utility.cpp Show resolved Hide resolved
src/unittest/test.cpp Outdated Show resolved Hide resolved
src/dpp/utility.cpp Outdated Show resolved Hide resolved
Copy link
Member

@Mishura4 Mishura4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

src/dpp/utility.cpp Outdated Show resolved Hide resolved
@braindigitalis braindigitalis dismissed Commandserver’s stale review September 15, 2023 18:32

doesn't seem to be a review?

@braindigitalis braindigitalis merged commit f490fd3 into brainboxdotcc:dev Sep 15, 2023
29 checks passed
Mishura4 pushed a commit to Mishura4/DPP-PRs that referenced this pull request Sep 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants