-
-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Created get_url methods for message, channel and user. #855
Conversation
✅ Deploy Preview for dpp-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice too see this feature here!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
doesn't seem to be a review?
feat: allow get_url methods for message, channel and user or as (user_url , message_url, channel_url, thread_url) in dpp::utility namespace.
test: created unit tests for all this methods.
Introduced new constant to dpp::utility namespace, called url_host (in analogy to cdn_host)
dev
branch.