Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix BUILD_VOICE_SUPPORT=OFF static build #1338

Merged
merged 2 commits into from
Dec 1, 2024
Merged

Conversation

Syping
Copy link
Contributor

@Syping Syping commented Nov 27, 2024

Building DPP statically with BUILD_VOICE_SUPPORT=OFF fails with undefined targets (related to HAVE_VOICE), so i put these targets in a if condition.

Code change checklist

  • I have ensured that all methods and functions are fully documented using doxygen style comments.
  • My code follows the coding style guide.
  • I tested that my change works before raising the PR.
  • I have ensured that I did not break any existing API calls.
  • I have not built my pull request using AI, a static analysis tool or similar without any human oversight.

@github-actions github-actions bot added the build Issue or Pull Request related to the build process label Nov 27, 2024
Copy link

netlify bot commented Nov 27, 2024

Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit 66d0e85
🔍 Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/674cbdbfa038fc0008f8c3d2
😎 Deploy Preview https://deploy-preview-1338--dpp-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Jaskowicz1 Jaskowicz1 merged commit e62aa6a into brainboxdotcc:dev Dec 1, 2024
48 checks passed
@Syping Syping deleted the dev branch December 2, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issue or Pull Request related to the build process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants