Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix broken static builds #1290

Merged
merged 8 commits into from
Oct 18, 2024
Merged

fix: fix broken static builds #1290

merged 8 commits into from
Oct 18, 2024

Conversation

braindigitalis
Copy link
Contributor

Fixes unix-like static builds (NOT windows)
NOTE: Does not static link libm. This is impossible on glibc without linking the rest of glibc, and macos seems happy enough to not static link libm too:
https://bugzilla.redhat.com/show_bug.cgi?id=1433347
https://stackoverflow.com/questions/56415996/linking-error-selective-static-linking-of-libm-a-in-gcc

Code change checklist

  • I have ensured that all methods and functions are fully documented using doxygen style comments.
  • My code follows the coding style guide.
  • I tested that my change works before raising the PR.
  • I have ensured that I did not break any existing API calls.
  • I have not built my pull request using AI, a static analysis tool or similar without any human oversight.

@github-actions github-actions bot added the build Issue or Pull Request related to the build process label Oct 18, 2024
Copy link

netlify bot commented Oct 18, 2024

Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit f04471e
🔍 Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/671285b8b19e9700081a15b0
😎 Deploy Preview https://deploy-preview-1290--dpp-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@braindigitalis braindigitalis marked this pull request as draft October 18, 2024 01:44
@braindigitalis braindigitalis marked this pull request as ready for review October 18, 2024 02:37
@braindigitalis braindigitalis merged commit 626157e into dev Oct 18, 2024
91 checks passed
@braindigitalis braindigitalis deleted the fix-staticbuild branch October 23, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issue or Pull Request related to the build process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when trying to configure a cmake build for static linking
2 participants