Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: libdave camel massacre 🐪🔪 #1285

Merged
merged 10 commits into from
Oct 16, 2024
Merged

Conversation

braindigitalis
Copy link
Contributor

Finally updates libdave to get rid of camelCase_ members with underscore on the end. This refactor updates:

  • Public and private variables that are part of a struct or class
  • Public and private class function names
  • Function name parameters

Where needed, a little reformatting.

TODO at a later date: Various parts of libdave mix and match uint64_t and std::string for snowflake storage. standardize them all on D++ dpp::snowflake where possible.

Code change checklist

  • I have ensured that all methods and functions are fully documented using doxygen style comments.
  • My code follows the coding style guide.
  • I tested that my change works before raising the PR.
  • I have ensured that I did not break any existing API calls.
  • I have not built my pull request using AI, a static analysis tool or similar without any human oversight.

@braindigitalis braindigitalis added the audio audio issues or feature requests label Oct 16, 2024
@braindigitalis braindigitalis self-assigned this Oct 16, 2024
Copy link

netlify bot commented Oct 16, 2024

Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit 4d1a420
🔍 Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/670fbfa269bedc00080e3294
😎 Deploy Preview https://deploy-preview-1285--dpp-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added documentation Improvements or additions to documentation code Improvements or additions to code. labels Oct 16, 2024
@ruslan-ilesik
Copy link
Contributor

🐍🔪🐪 => DPP

src/dpp/dave/codec_utils.cpp Outdated Show resolved Hide resolved
src/dpp/dave/codec_utils.cpp Outdated Show resolved Hide resolved
src/dpp/dave/cryptor_manager.cpp Outdated Show resolved Hide resolved
src/dpp/dave/decryptor.cpp Outdated Show resolved Hide resolved
src/dpp/dave/decryptor.cpp Outdated Show resolved Hide resolved
src/dpp/dave/version.h Outdated Show resolved Hide resolved
Copy link
Contributor

@Jaskowicz1 Jaskowicz1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Thank ya for getting rid of camelCase

@braindigitalis braindigitalis requested review from Jaskowicz1 and removed request for Jaskowicz1 October 16, 2024 13:47
@braindigitalis braindigitalis merged commit 5c6dcec into dev Oct 16, 2024
92 checks passed
@braindigitalis braindigitalis deleted the libdave-camelum-occisio branch October 16, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
audio audio issues or feature requests code Improvements or additions to code. documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants