-
-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: libdave camel massacre 🐪🔪 #1285
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_key_pair, scope_exit, session, user_credential, util, version
✅ Deploy Preview for dpp-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
github-actions
bot
added
documentation
Improvements or additions to documentation
code
Improvements or additions to code.
labels
Oct 16, 2024
🐍🔪🐪 => DPP |
Jaskowicz1
requested changes
Oct 16, 2024
Jaskowicz1
approved these changes
Oct 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! Thank ya for getting rid of camelCase
braindigitalis
requested review from
Jaskowicz1
and removed request for
Jaskowicz1
October 16, 2024 13:47
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
audio
audio issues or feature requests
code
Improvements or additions to code.
documentation
Improvements or additions to documentation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally updates libdave to get rid of
camelCase_
members with underscore on the end. This refactor updates:Where needed, a little reformatting.
TODO at a later date: Various parts of libdave mix and match uint64_t and std::string for snowflake storage. standardize them all on D++
dpp::snowflake
where possible.Code change checklist