Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: low level socket tidyups and removal of punning #1282

Merged
merged 5 commits into from
Oct 16, 2024
Merged

refactor: low level socket tidyups and removal of punning #1282

merged 5 commits into from
Oct 16, 2024

Conversation

braindigitalis
Copy link
Contributor

@braindigitalis braindigitalis commented Oct 16, 2024 •
edited
Loading

cleans up low level socket functionality, adding some new classes and exposing some internal classes to public interface.
Cleans up dns caching.

Code change checklist

  • I have ensured that all methods and functions are fully documented using doxygen style comments.
  • My code follows the coding style guide.
  • I tested that my change works before raising the PR.
  • I have ensured that I did not break any existing API calls.
  • I have not built my pull request using AI, a static analysis tool or similar without any human oversight.

@github-actions GitHub Actions
Copy link
Contributor

Thank you for your contribution, but PRs must be raised against the dev branch. Please log your pull request against the dev branch not master. You can also retarget this pull request, then reopen it.

@github-actions github-actions bot closed this Oct 16, 2024
@github-actions github-actions bot added documentation Improvements or additions to documentation code Improvements or additions to code. labels Oct 16, 2024
@braindigitalis braindigitalis changed the base branch from master to dev October 16, 2024 01:16
@netlify Netlify
Copy link

netlify bot commented Oct 16, 2024 •
edited
Loading

✅ Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit 4e86993
🔍 Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/670f1693762ee20008c898ef
😎 Deploy Preview https://deploy-preview-1282--dpp-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@braindigitalis braindigitalis self-assigned this Oct 16, 2024
@braindigitalis braindigitalis marked this pull request as ready for review October 16, 2024 02:16
RealTimeChris
RealTimeChris approved these changes Oct 16, 2024
View reviewed changes
Copy link
Member

@RealTimeChris RealTimeChris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Mishura4
Mishura4 approved these changes Oct 16, 2024
View reviewed changes
Copy link
Member

@Mishura4 Mishura4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ship it 🚢

@braindigitalis braindigitalis merged commit 4965b5c into dev Oct 16, 2024
91 checks passed
@braindigitalis braindigitalis deleted the socket-cleanup branch October 16, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jaskowicz1 Jaskowicz1 Jaskowicz1 approved these changes

@RealTimeChris RealTimeChris RealTimeChris approved these changes

@Mishura4 Mishura4 Mishura4 approved these changes

Assignees

@braindigitalis braindigitalis

Labels
code Improvements or additions to code. documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@braindigitalis @Mishura4 @RealTimeChris @Jaskowicz1