Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(breaking): Deprecate sync calls #1280

Merged
merged 3 commits into from
Oct 14, 2024
Merged

Conversation

braindigitalis
Copy link
Contributor

Deprecate sync calls, from now on they will be auto generated with DPP_DEPRECATED on them advising users to use coro.

This bypasses sync depreciation warnings in the unit tests by using the template directly instead. I don't want to touch this with a ten foot pole right now as this is a whole world of fragile callback hell. This can be addressed in the future maybe, but for now, this isnt directly end user facing code and isnt going to cause anyone any hassle.

Code change checklist

  • I have ensured that all methods and functions are fully documented using doxygen style comments.
  • My code follows the coding style guide.
  • I tested that my change works before raising the PR.
  • I have ensured that I did not break any existing API calls.
  • I have not built my pull request using AI, a static analysis tool or similar without any human oversight.

…to generated with DPP_DEPRECATED on them advising users to use coro.
…ted warning for now by using the sync template directly. I don't want to touch this with a ten foot pole right now as this is a whole world of callback hell
@braindigitalis braindigitalis self-assigned this Oct 14, 2024
Copy link

netlify bot commented Oct 14, 2024

Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit e1b40b2
🔍 Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/670d24cd03a1fa0009adb74d
😎 Deploy Preview https://deploy-preview-1280--dpp-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added documentation Improvements or additions to documentation build Issue or Pull Request related to the build process code Improvements or additions to code. labels Oct 14, 2024
@ruslan-ilesik
Copy link
Contributor

Imho, we should fully remove them when we will be c++20 lib by default. Because coro can directly replace sync calls without blocking and callback hell

@braindigitalis
Copy link
Contributor Author

Imho, we should fully remove them when we will be c++20 lib by default. Because coro can directly replace sync calls without blocking and callback hell

agreed, that likely still isnt for a long time though...

@braindigitalis braindigitalis merged commit b720cc6 into dev Oct 14, 2024
92 checks passed
@braindigitalis braindigitalis deleted the burn-it-with-fire branch October 14, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issue or Pull Request related to the build process code Improvements or additions to code. documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants