refactor(breaking): Deprecate sync calls #1280
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecate sync calls, from now on they will be auto generated with DPP_DEPRECATED on them advising users to use coro.
This bypasses sync depreciation warnings in the unit tests by using the template directly instead. I don't want to touch this with a ten foot pole right now as this is a whole world of fragile callback hell. This can be addressed in the future maybe, but for now, this isnt directly end user facing code and isnt going to cause anyone any hassle.
Code change checklist