Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAVE user join/part #1276

Merged
merged 2 commits into from
Oct 14, 2024
Merged

DAVE user join/part #1276

merged 2 commits into from
Oct 14, 2024

Conversation

Neko-Life
Copy link
Member

@Neko-Life Neko-Life commented Oct 13, 2024 •
edited
Loading

Changes in this PR

  • Fix dave user join/part implementation

Notes

  • Tested update_rachets for more than 2 dave user (including bot) is joining/leaving the voice channel
  • Tested Upgrade/Downgrade to/from dave when non-dave user join/leave the voice channel

Code change checklist

  • I have ensured that all methods and functions are fully documented using doxygen style comments.
  • My code follows the coding style guide.
  • I tested that my change works before raising the PR.
  • I have ensured that I did not break any existing API calls.
  • I have not built my pull request using AI, a static analysis tool or similar without any human oversight.

@Neko-Life Neko-Life marked this pull request as draft October 13, 2024 19:14
@github-actions github-actions bot added documentation Improvements or additions to documentation code Improvements or additions to code. labels Oct 13, 2024
@braindigitalis
Copy link
Contributor

nice! look forward to merging in once CI passes and you're ready!
thanks for the effort!

@braindigitalis braindigitalis added audio audio issues or feature requests DAVE Issues or pull requests relating to DAVE E2EE labels Oct 13, 2024
@Neko-Life Neko-Life marked this pull request as ready for review October 14, 2024 04:57
@braindigitalis
Copy link
Contributor

to be fixed once merged to my branch

@braindigitalis braindigitalis merged commit 5fa9101 into brainboxdotcc:dave-join-part Oct 14, 2024
27 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@braindigitalis braindigitalis braindigitalis approved these changes

Assignees

@Neko-Life Neko-Life

Labels
audio audio issues or feature requests code Improvements or additions to code. DAVE Issues or pull requests relating to DAVE E2EE documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Neko-Life @braindigitalis