Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: crash in threads_get_public_archived #1268

Merged
merged 1 commit into from
Oct 12, 2024
Merged

fix: crash in threads_get_public_archived #1268

merged 1 commit into from
Oct 12, 2024

Conversation

braindigitalis
Copy link
Contributor

@braindigitalis braindigitalis commented Oct 12, 2024 •
edited
Loading

threads_get_public_archived crashes as it does not contain thread_metadata, which is assumed present in thread::fill_from_json_impl

Fixes #1269

Code change checklist

  • I have ensured that all methods and functions are fully documented using doxygen style comments.
  • My code follows the coding style guide.
  • I tested that my change works before raising the PR.
  • I have ensured that I did not break any existing API calls.
  • I have not built my pull request using AI, a static analysis tool or similar without any human oversight.

@braindigitalis braindigitalis self-assigned this Oct 12, 2024
@netlify Netlify
Copy link

netlify bot commented Oct 12, 2024 •
edited
Loading

✅ Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit ad8d0b8
🔍 Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/670a631b2b43df0008feb9ac
😎 Deploy Preview https://deploy-preview-1268--dpp-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@braindigitalis braindigitalis linked an issue Oct 12, 2024 that may be closed by this pull request
Crash when calling dpp::cluster::threads_get_public_archived #1269
Closed
@github-actions github-actions bot added the code Improvements or additions to code. label Oct 12, 2024
@braindigitalis braindigitalis added the bug Something isn't working label Oct 12, 2024
@braindigitalis braindigitalis merged commit a1a32d2 into dev Oct 12, 2024
93 checks passed
@braindigitalis braindigitalis deleted the fix-threads-archived branch October 12, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jaskowicz1 Jaskowicz1 Jaskowicz1 approved these changes

@Mishura4 Mishura4 Awaiting requested review from Mishura4

@RealTimeChris RealTimeChris Awaiting requested review from RealTimeChris

Assignees

@braindigitalis braindigitalis

Labels
bug Something isn't working code Improvements or additions to code.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crash when calling dpp::cluster::threads_get_public_archived
2 participants
@braindigitalis @Jaskowicz1