refactor: why you so salty? Entirely remove libsodium from D++ #1265
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR completely removes libsodium as a dependency for voice in D++. No longer do we have to be all salty.
The replement uses OpenSSL primitives instead, plus a pair of functions i lifted from BoringSSL (due credit given) and converted from ugly macros to constexpr.
All build systems that look for and include/link sodium have been adjusted to remove it from the library. All documentation no longer refers to sodium. Note that we do keep previous verisons documentation which will still correctly refer to sodium for those versions.
Code change checklist
Note: GPT used to help explain what HChaCha20 actually is and its role in nonce expansion. Some of the comment docblocks have their origin from the evil AI.