Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: DAVE! client join/part re-derive client ratchets and privacy code #1264

Merged
merged 9 commits into from
Oct 14, 2024
Merged

fix: DAVE! client join/part re-derive client ratchets and privacy code #1264

merged 9 commits into from
Oct 14, 2024

Conversation

braindigitalis
Copy link
Contributor

@braindigitalis braindigitalis commented Oct 9, 2024 •
edited
Loading

Fixes re-derive of ratchets when users change in MLS group. Needs testing with multiple mls alts in vc.

Also fixes on_voice_ready not being emitted when bot is first in vc, with dave enabled, and new user joins vc with dave enabled.

For a future PR: Timeout on on_ready, so if no new user turns up within X seconds to a DAVE channel, we fire on_ready anyway.

Code change checklist

  • I have ensured that all methods and functions are fully documented using doxygen style comments.
  • My code follows the coding style guide.
  • I tested that my change works before raising the PR.
  • I have ensured that I did not break any existing API calls.
  • I have not built my pull request using AI, a static analysis tool or similar without any human oversight.

@braindigitalis braindigitalis added the audio audio issues or feature requests label Oct 9, 2024
@braindigitalis braindigitalis self-assigned this Oct 9, 2024
@netlify Netlify
Copy link

netlify bot commented Oct 9, 2024 •
edited
Loading

✅ Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit 8a50c58
🔍 Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/670d21833a70e70008ca6cfc
😎 Deploy Preview https://deploy-preview-1264--dpp-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@braindigitalis braindigitalis changed the title fix: client join/part re-derive client ratchets and privacy code fix: DAVE! client join/part re-derive client ratchets and privacy code Oct 9, 2024
@github-actions github-actions bot added documentation Improvements or additions to documentation code Improvements or additions to code. labels Oct 9, 2024
@braindigitalis braindigitalis added the DAVE Issues or pull requests relating to DAVE E2EE label Oct 13, 2024
@braindigitalis braindigitalis marked this pull request as ready for review October 14, 2024 08:56
@braindigitalis
Copy link
Contributor Author

image

RealTimeChris
RealTimeChris approved these changes Oct 14, 2024
View reviewed changes
Copy link
Member

@RealTimeChris RealTimeChris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Nice work.

@braindigitalis braindigitalis merged commit fe6f15f into dev Oct 14, 2024
92 checks passed
@braindigitalis braindigitalis deleted the dave-join-part branch October 14, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jaskowicz1 Jaskowicz1 Jaskowicz1 approved these changes

@RealTimeChris RealTimeChris RealTimeChris approved these changes

Assignees

@braindigitalis braindigitalis

Labels
audio audio issues or feature requests code Improvements or additions to code. DAVE Issues or pull requests relating to DAVE E2EE documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@braindigitalis @RealTimeChris @Jaskowicz1 @Neko-Life