Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test): fix ban unit tests to be dependent upon each other #1200

Merged
merged 3 commits into from
Jul 17, 2024

Conversation

braindigitalis
Copy link
Contributor

Fixes the ban set/unset/get unit tests to be properly dependent upon each other's callbacks (callback hell, yay) and also to use the IDs of valid users which should never be on a unit test server:

  • MEE6
  • Dyno
  • MidJourney Bot

These 3 will remain valid for the forseeable future. using deleted user ids for bans is not a good idea, they eventually get purged and the side effects of adding bans for them is not doucmented behaviour.

Code change checklist

  • I have ensured that all methods and functions are fully documented using doxygen style comments.
  • My code follows the coding style guide.
  • I tested that my change works before raising the PR.
  • I have ensured that I did not break any existing API calls.
  • I have not built my pull request using AI, a static analysis tool or similar without any human oversight.

@braindigitalis braindigitalis self-assigned this Jul 16, 2024
Copy link

netlify bot commented Jul 16, 2024

Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit 3f2b333
🔍 Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/6696e281f9372f00082e9efa
😎 Deploy Preview https://deploy-preview-1200--dpp-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@braindigitalis braindigitalis added the bug Something isn't working label Jul 16, 2024
@github-actions github-actions bot added the code Improvements or additions to code. label Jul 16, 2024
@Jaskowicz1 Jaskowicz1 merged commit 4ff0420 into dev Jul 17, 2024
7 checks passed
@Jaskowicz1 Jaskowicz1 deleted the fix-ban-unit-test branch July 23, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working code Improvements or additions to code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants