fix(test): fix ban unit tests to be dependent upon each other #1200
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the ban set/unset/get unit tests to be properly dependent upon each other's callbacks (callback hell, yay) and also to use the IDs of valid users which should never be on a unit test server:
These 3 will remain valid for the forseeable future. using deleted user ids for bans is not a good idea, they eventually get purged and the side effects of adding bans for them is not doucmented behaviour.
Code change checklist