Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ts_not_null now works for all timezones #1089

Merged
merged 3 commits into from
Feb 19, 2024

Conversation

Jaskowicz1
Copy link
Contributor

This PR fixes the ts_not_null unittest breaking on a non-UTC machine. It also fixes set_ts_not_null.

For more understanding, mktime returns a local time, not a UTC time. It's also not based off your BIOS time, as previously assumed in #1063, but rather the user-level time.

Fixes #1063

Code change checklist

  • I have ensured that all methods and functions are fully documented using doxygen style comments.
  • My code follows the coding style guide.
  • I tested that my change works before raising the PR.
  • I have ensured that I did not break any existing API calls.
  • I have not built my pull request using AI, a static analysis tool or similar without any human oversight.

@Jaskowicz1 Jaskowicz1 self-assigned this Feb 19, 2024
Copy link

netlify bot commented Feb 19, 2024

Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit ef5816c
🔍 Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/65d3545aeef2b200081b68e9
😎 Deploy Preview https://deploy-preview-1089--dpp-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the code Improvements or additions to code. label Feb 19, 2024
Copy link

netlify bot commented Feb 19, 2024

Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit d41009c
🔍 Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/65d357450ff85a00089566e3
😎 Deploy Preview https://deploy-preview-1089--dpp-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Jaskowicz1 Jaskowicz1 linked an issue Feb 19, 2024 that may be closed by this pull request
@braindigitalis braindigitalis merged commit 9c549f5 into brainboxdotcc:dev Feb 19, 2024
43 checks passed
@Jaskowicz1 Jaskowicz1 deleted the timestamp_change branch June 13, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code Improvements or additions to code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 test fails: ts_not_null()
2 participants