Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed getting archived threads #1082

Merged
merged 1 commit into from
Feb 16, 2024
Merged

Conversation

CMDisme
Copy link
Contributor

@CMDisme CMDisme commented Feb 16, 2024

Used get_active_threads as a template to properly implement threads_get_public_archived and threads_get_private_archived

Code change checklist

  • I have ensured that all methods and functions are fully documented using doxygen style comments.
  • My code follows the coding style guide.
  • I tested that my change works before raising the PR.
  • I have ensured that I did not break any existing API calls.
  • I have not built my pull request using AI, a static analysis tool or similar without any human oversight.

Used get_active_threads as a template to properly implement threads_get_public_archived and threads_get_private_archived
Copy link

netlify bot commented Feb 16, 2024

Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit 44f09be
🔍 Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/65cf9ec81be6e200089dcfd4
😎 Deploy Preview https://deploy-preview-1082--dpp-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the code Improvements or additions to code. label Feb 16, 2024
@Jaskowicz1 Jaskowicz1 changed the title Fixed getting archived threads fix: Fixed getting archived threads Feb 16, 2024
@CLAassistant
Copy link

CLAassistant commented Feb 16, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@Mishura4 Mishura4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for contributing! Just a minor thing and then good to go for me

src/dpp/cluster/thread.cpp Show resolved Hide resolved
src/dpp/cluster/thread.cpp Show resolved Hide resolved
Copy link
Contributor Author

@CMDisme CMDisme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is used.

@CMDisme CMDisme requested a review from Mishura4 February 16, 2024 19:14
@Mishura4
Copy link
Member

👍TODO: do the thing. Later, at some point

@Mishura4 Mishura4 merged commit 4334c94 into brainboxdotcc:dev Feb 16, 2024
42 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code Improvements or additions to code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants