-
-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #936: Refactor Unit Test #1080
Conversation
✅ Deploy Preview for dpp-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
105 tests were skipped, does this still work with online tests? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please check requested changes :)
src/unittest/test.h
Outdated
/** | ||
* @brief Perform a test of a REST base API call with one parameter that returns a list | ||
*/ | ||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
weird spacing again
unit test with token -
|
Thanks for contributing! Make sure you run the full suite of tests including online tests. You'll need to set a couple environment variables, see https://dpp.dev/unit-tests.html Also pass "full" as the first command argument for some extra tests |
Thanks for the suggestion, I was looking for environment variables details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contributing! Your PR seems to be a near copy-paste of #948 with some minor modifications, was this intended? I'm also assuming you based this PR off that PR as you're attempting to remove Mac support (which was added after #948).
Please correct the Mac support issue, along with the fails shown in your results!
Hi there, are you currently working on readding mac support and fixing the other issues? You seemed to fix the space indentation but left everything else. |
We've closed this PR due to no activity. The PR also seems to be a direct copy of an old PR that was raised, with some additions. This also breaks our OSX support. |
Results from unittest.exe -
Execution finished in 32.298 seconds. Failed: 0 Passed: 56 Skipped: 105 Percentage: 100.00%
[ Please outline your change here. Be sure to check the checkboxes below. ]
Code change checklist