Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix bug in human readable errors #1077

Merged
merged 1 commit into from
Feb 15, 2024
Merged

Conversation

Mishura4
Copy link
Member

@Mishura4 Mishura4 commented Feb 3, 2024

The error parser would stop at the first field (here "thumbnail") on something like this, and show "Invalid Form Body":

{
    "message": "Invalid Form Body",
    "code": 50035,
    "errors": {
        "embeds": {
            "0": {
                "thumbnail": {
                    "url": {
                        "_errors": [
                            {"code": "URL_TYPE_INVALID_URL", "message": "Not a well formed URL."}
                        ]
                    }
                }
            }
        }
    }
}

Code change checklist

  • I have ensured that all methods and functions are fully documented using doxygen style comments.
  • My code follows the coding style guide.
  • I tested that my change works before raising the PR.
  • I have ensured that I did not break any existing API calls.
  • I have not built my pull request using AI, a static analysis tool or similar without any human oversight.

Copy link

netlify bot commented Feb 3, 2024

Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit 6a47c6e
🔍 Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/65bed1fd7888af0008c137bb
😎 Deploy Preview https://deploy-preview-1077--dpp-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the code Improvements or additions to code. label Feb 3, 2024
@braindigitalis braindigitalis merged commit 053e6ca into brainboxdotcc:dev Feb 15, 2024
43 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code Improvements or additions to code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants