Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added dpp::cluster::guild_member_timeout_remove and its sync/coro versions #1067

Merged
merged 6 commits into from
Jan 25, 2024

Conversation

AA1999
Copy link
Contributor

@AA1999 AA1999 commented Jan 21, 2024

I've added dpp::cluster::guild_member_timeout_remove, dpp::cluster::guild_member_timeout_remove_sync and dpp::cluster::co_guild_member_timeout_remove and added documentation for them.

…sions which is just a shortcut of the normal dpp::cluster::guild_member_timeout with the communication_disable_until variable set to 0. This is added for user convenience. Also added documentation for all versions.
@CLAassistant
Copy link

CLAassistant commented Jan 21, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

netlify bot commented Jan 21, 2024

Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit 24385b5
🔍 Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/65b0f566831ddb000739399a
😎 Deploy Preview https://deploy-preview-1067--dpp-dev.netlify.app/classdpp_1_1cluster
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@braindigitalis
Copy link
Contributor

how did you add the coro and sync version? did you do it by rerunning the builder scripts for it?

@AA1999
Copy link
Contributor Author

AA1999 commented Jan 21, 2024

I just called guild_timeout_remove_sync and co_guild_timeout with communication_disabled_until set to 0
Returned the result in the coro version

@braindigitalis
Copy link
Contributor

the coro and sync are auto generated, you shouldn't manually put stuff in those files. when someone runs cmake it will remove your changes.

you need to make sure the auto generation picks up your changes. because they don't match the correct pattern this won't work as is. you should make them not just call another function and instead call the REST stuff

@AA1999
Copy link
Contributor Author

AA1999 commented Jan 21, 2024

Where's the script for these?
Is it in one of the CMakeLists?
Also why not call the function with a 0 parameter if I'm doing the exact same thing with one different variable?

@Jaskowicz1
Copy link
Contributor

Where's the script for these? Is it in one of the CMakeLists? Also why not call the function with a 0 parameter if I'm doing the exact same thing with one different variable?

No, it happens when you call cmake -B build or cmake ..

@AA1999
Copy link
Contributor Author

AA1999 commented Jan 21, 2024

I did use cmake -B and cmake --build before pushing
Dunno if that'd help or not

@braindigitalis
Copy link
Contributor

it's a set of php scripts in the buildtools folder that do this, there's a base class, and a derived version of it for coro and sync.

you should not need to modify these scripts.

Copy link
Contributor

@Jaskowicz1 Jaskowicz1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better this time around!

@Jaskowicz1 Jaskowicz1 merged commit aaffc5c into brainboxdotcc:dev Jan 25, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants