-
-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added dpp::cluster::guild_member_timeout_remove and its sync/coro versions #1067
Conversation
…sions which is just a shortcut of the normal dpp::cluster::guild_member_timeout with the communication_disable_until variable set to 0. This is added for user convenience. Also added documentation for all versions.
✅ Deploy Preview for dpp-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…me reason (assuming because DPP_CORO wasn't on)
how did you add the coro and sync version? did you do it by rerunning the builder scripts for it? |
I just called guild_timeout_remove_sync and co_guild_timeout with communication_disabled_until set to 0 |
the coro and sync are auto generated, you shouldn't manually put stuff in those files. when someone runs cmake it will remove your changes. you need to make sure the auto generation picks up your changes. because they don't match the correct pattern this won't work as is. you should make them not just call another function and instead call the REST stuff |
Where's the script for these? |
No, it happens when you call |
I did use cmake -B and cmake --build before pushing |
it's a set of php scripts in the buildtools folder that do this, there's a base class, and a derived version of it for coro and sync. you should not need to modify these scripts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better this time around!
I've added dpp::cluster::guild_member_timeout_remove, dpp::cluster::guild_member_timeout_remove_sync and dpp::cluster::co_guild_member_timeout_remove and added documentation for them.