Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added expire and issued timestamps in attachment #1065

Merged
merged 4 commits into from
Jan 29, 2024

Conversation

harrrson
Copy link
Contributor

Added methods to extract expiration and issued timestamps from url

dpp::embed test{};
test.set_title("Test for file")
    .add_field("filename", fileAttachment.filename)
    .add_field("description", fileAttachment.description)
    .add_field("url", fileAttachment.url)
    .add_field("proxy_url", fileAttachment.proxy_url)
    .add_field("Expiration timestamp", std::to_string(fileAttachment.get_expire_time()))
    .add_field("issuing timestamp", std::to_string(fileAttachment.get_issued_time()));

obraz

Code change checklist

  • I have ensured that all methods and functions are fully documented using doxygen style comments.
  • My code follows the coding style guide.
  • I tested that my change works before raising the PR.
  • I have ensured that I did not break any existing API calls.
  • I have not built my pull request using AI, a static analysis tool or similar without any human oversight.

Copy link

netlify bot commented Jan 18, 2024

Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit e9522ab
🔍 Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/65b2e7d39fbd8b00084e86c2
😎 Deploy Preview https://deploy-preview-1065--dpp-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

src/dpp/message.cpp Show resolved Hide resolved
src/dpp/message.cpp Outdated Show resolved Hide resolved
src/dpp/message.cpp Outdated Show resolved Hide resolved
@Jaskowicz1 Jaskowicz1 added enhancement New feature or request code Improvements or additions to code. labels Jan 25, 2024
Copy link
Contributor

@braindigitalis braindigitalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved and good to merge, would be nice if there were unit tests for this though

@Jaskowicz1
Copy link
Contributor

approved and good to merge, would be nice if there were unit tests for this though

A todo list for stuff would be lovely

@Jaskowicz1 Jaskowicz1 merged commit 81d4875 into brainboxdotcc:dev Jan 29, 2024
42 of 43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code Improvements or additions to code. enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants