Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cmyk calculations - blue value calculations #1053

Merged
merged 1 commit into from
Dec 29, 2023
Merged

fix: cmyk calculations - blue value calculations #1053

merged 1 commit into from
Dec 29, 2023

Conversation

harrrson
Copy link
Contributor

During conversion from cmyk to rgb, blue value was calculated with m (magenta) instead of k (black)

Code change checklist

  • I have ensured that all methods and functions are fully documented using doxygen style comments.
  • My code follows the coding style guide.
  • I tested that my change works before raising the PR.
  • I have ensured that I did not break any existing API calls.
  • I have not built my pull request using AI, a static analysis tool or similar without any human oversight.

Copy link

netlify bot commented Dec 29, 2023

Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit c27212f
🔍 Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/658f3349e8a9bd0008fc3a99
😎 Deploy Preview https://deploy-preview-1053--dpp-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the code Improvements or additions to code. label Dec 29, 2023
@braindigitalis
Copy link
Contributor

thanks for the PR! we will merge this when the CI completes

@Jaskowicz1 Jaskowicz1 merged commit 00febe4 into brainboxdotcc:dev Dec 29, 2023
43 checks passed
@harrrson harrrson deleted the cmyk_fix branch December 29, 2023 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code Improvements or additions to code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants