fix: properly free ssl session and ssl context #1049
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
SSL_CTX
is freed withSSL_CTX_free
by usingstd::unique_ptr
with custom deleter. Previously was leaking.SSL
is freed withSSL_free
inssl_client::cleanup()
. Previously was leaking.try-catch
. If it failed to allocate, you have nothing to deallocate. The assignment doesn't even happen in this case, an exception is thrown when evaluating the right side.Code change checklist