fix: use of uninitialized value in command_option copy ctor #1044
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically all examples of using
dpp::command_option
invoke undefined behavior. Let's look at its typical usage example from the docs:The problem here is that
dpp::command_option::command_option
does not initialize a boolean field calledfocused
. And then insideadd_option
the implicitly-defined copy constructor is called. This constructor, among other things, copies thatfocused
field, but since it was never initialized, we get UB.This PR ensures that
focused
is initialized indpp::command_option::command_option
withfalse
.Code change checklist