Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Added emoji page #1019

Merged
merged 14 commits into from
Dec 7, 2023
Merged

docs: Added emoji page #1019

merged 14 commits into from
Dec 7, 2023

Conversation

Henonicks
Copy link
Contributor

@Henonicks Henonicks commented Nov 28, 2023 •
edited
Loading

emoji page yay

Documentation change checklist

  • My documentation changes follow the docs style guide and any code examples follow the coding style guide.
  • I tested that my change works before raising the PR (via running doxygen, and testing examples).
  • I have not moved any existing pages or changed any existing URLs without strong justification as to why.
  • I have not generated content using AI or a desktop utility such as grammarly.

@netlify Netlify
Copy link

netlify bot commented Nov 28, 2023 •
edited
Loading

✅ Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit 13a6c53
🔍 Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/6571f5b177733f000827a02d
😎 Deploy Preview https://deploy-preview-1019--dpp-dev.netlify.app/using-emojis
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Henonicks Henonicks changed the title Added emoji page docs: Added emoji page Nov 28, 2023
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Nov 28, 2023
@Jaskowicz1 Jaskowicz1 assigned Jaskowicz1 and unassigned Jaskowicz1 Nov 28, 2023
@Jaskowicz1 Jaskowicz1 self-requested a review November 28, 2023 16:56
Jaskowicz1
Jaskowicz1 reviewed Nov 28, 2023
View reviewed changes
docpages/example_programs/misc/using_emoji.md Outdated Show resolved Hide resolved
docpages/example_code/using_emoji.cpp Outdated Show resolved Hide resolved
docpages/example_programs/misc/using_emoji.md Outdated Show resolved Hide resolved
@Jaskowicz1
Copy link
Contributor

If you could add an image at the end of the page, showing the results, that would be great!

@Henonicks
Copy link
Contributor Author

If you could add an image at the end of the page, showing the results, that would be great!

That was in my plans, I just wanted to make this draft

@Jaskowicz1
Copy link
Contributor

If you could add an image at the end of the page, showing the results, that would be great!

That was in my plans, I just wanted to make this draft

Ah rightio, no worries just wanted to make sure :)

@Henonicks Henonicks requested a review from Jaskowicz1 November 29, 2023 13:19
@Henonicks
Copy link
Contributor Author

Gotta fix the top of the page

Jaskowicz1
Jaskowicz1 requested changes Nov 29, 2023
View reviewed changes
docpages/example_code/using_emoji.cpp Outdated Show resolved Hide resolved
docpages/example_code/using_emoji.cpp Outdated Show resolved Hide resolved
docpages/example_programs/misc/using-emoji.md Outdated Show resolved Hide resolved
@Henonicks
Copy link
Contributor Author

I have to test indentation

@Henonicks
Copy link
Contributor Author

It works now, just have to push it

Jaskowicz1
Jaskowicz1 requested changes Dec 3, 2023
View reviewed changes
Copy link
Contributor

@Jaskowicz1 Jaskowicz1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If your PR is ready for review, please unmark it as draft, that will help us know that this review was wanted.

docpages/example_code/using_emoji1.cpp Outdated Show resolved Hide resolved
docpages/example_code/using_emoji1.cpp Outdated Show resolved Hide resolved
docpages/example_code/using_emoji3.cpp Outdated Show resolved Hide resolved
docpages/example_code/using_emoji3.cpp Outdated Show resolved Hide resolved
docpages/example_programs/misc/using-emoji.md Outdated Show resolved Hide resolved
docpages/example_programs/misc/using-emoji.md Outdated Show resolved Hide resolved
docpages/example_programs/misc/using-emoji.md Outdated Show resolved Hide resolved
docpages/example_programs/misc/using-emoji.md Outdated Show resolved Hide resolved
docpages/example_programs/misc/using-emoji.md Outdated Show resolved Hide resolved
@Henonicks Henonicks marked this pull request as ready for review December 4, 2023 07:13
Jaskowicz1
Jaskowicz1 requested changes Dec 4, 2023
View reviewed changes
docpages/example_code/using_emojis1.cpp Outdated Show resolved Hide resolved
docpages/example_code/using_emojis3.cpp Outdated Show resolved Hide resolved
docpages/example_programs/misc/using-emojis.md Outdated Show resolved Hide resolved
@Henonicks Henonicks requested a review from Jaskowicz1 December 4, 2023 12:04
Jaskowicz1
Jaskowicz1 requested changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@Jaskowicz1 Jaskowicz1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one thing

docpages/example_programs/misc/using-emojis.md Outdated Show resolved Hide resolved
@Henonicks Henonicks requested a review from Mishura4 December 4, 2023 12:41
@Jaskowicz1 Jaskowicz1 requested review from Mishura4 and removed request for Mishura4 December 4, 2023 12:42
@Jaskowicz1
Copy link
Contributor

Didn't mean to remove mishura from review there 😅

@Mishura4
Copy link
Member

Mishura4 commented Dec 4, 2023

1084205795769593958.png

Mishura4
Mishura4 requested changes Dec 4, 2023
View reviewed changes
docpages/example_programs/misc.md Outdated Show resolved Hide resolved
@Jaskowicz1 Jaskowicz1 mentioned this pull request Dec 5, 2023
Merged
@Henonicks Henonicks requested a review from Mishura4 December 6, 2023 18:03
Jaskowicz1
Jaskowicz1 requested changes Dec 6, 2023
View reviewed changes
docpages/example_programs/misc.md Outdated Show resolved Hide resolved
docpages/example_programs/misc/using-emojis.md Outdated Show resolved Hide resolved
@Jaskowicz1
Copy link
Contributor

Just gonna investigate why dpp::exception_error_code::err_unknown_emoji isn't linking on the preview before I approve.

@Mishura4 Mishura4 merged commit 58424c3 into brainboxdotcc:dev Dec 7, 2023
11 checks passed
@Henonicks Henonicks deleted the to_push branch April 15, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jaskowicz1 Jaskowicz1 Jaskowicz1 approved these changes

@Mishura4 Mishura4 Mishura4 approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Henonicks @Jaskowicz1 @Mishura4 @braindigitalis