Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Mac changes, self-hosted runner now available #1010

Merged
merged 4 commits into from
Nov 20, 2023

Conversation

Jaskowicz1
Copy link
Contributor

This PR changes the ci.yml workflow to now use a matrix for MacOS. This also means we now have a self-hosted Mac runner (using Apple silicone) available!

@Jaskowicz1 Jaskowicz1 self-assigned this Nov 19, 2023
Copy link

netlify bot commented Nov 19, 2023

Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit 3fbfc8d
🔍 Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/655b1f10e9e20c000858809e
😎 Deploy Preview https://deploy-preview-1010--dpp-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Jaskowicz1
Copy link
Contributor Author

Timezone will be changed on the Mac VM to be UTC in a few hours. That should fix the unit test.

I also want to note, I’ve purposefully made it so both Mac architectures run the unit test, as a precaution. Though, I would like to look into the possibility of running two online unit tests (one on Linux, one on Mac arm64)

@braindigitalis
Copy link
Contributor

the only way to have two concurrent runners is to have two tokens and two test servers with different channel, bot and event IDs. it would likely be overkill, plus each would need to be limited to one at a time like the Linux unit tests run is.

@Jaskowicz1
Copy link
Contributor Author

the only way to have two concurrent runners is to have two tokens and two test servers with different channel, bot and event IDs. it would likely be overkill, plus each would need to be limited to one at a time like the Linux unit tests run is.

Ah right, yeah that's fair enough.

@Jaskowicz1
Copy link
Contributor Author

Timezone has been fixed on the Mac (it appeared to be under PST, it is now under UTC) and the CI has passed. This PR is ready!

@braindigitalis
Copy link
Contributor

Timezone has been fixed on the Mac (it appeared to be under PST, it is now under UTC) and the CI has passed. This PR is ready!

what, don't you know? EVERYONE lives in the USA 😆

@Jaskowicz1
Copy link
Contributor Author

Timezone has been fixed on the Mac (it appeared to be under PST, it is now under UTC) and the CI has passed. This PR is ready!

what, don't you know? EVERYONE lives in the USA 😆

🤣

@Jaskowicz1
Copy link
Contributor Author

Downscaled the VM due to it requesting a lot of resources. Will re-run the action to make sure it hasn't slowed down too much.

@Jaskowicz1
Copy link
Contributor Author

Job finished in 3 minutes 48 seconds, even when downscaled!

@Jaskowicz1 Jaskowicz1 merged commit 418602c into brainboxdotcc:dev Nov 20, 2023
35 checks passed
@Jaskowicz1 Jaskowicz1 deleted the mac-arm64-runner branch November 20, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants