-
-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Mac changes, self-hosted runner now available #1010
Conversation
✅ Deploy Preview for dpp-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Timezone will be changed on the Mac VM to be UTC in a few hours. That should fix the unit test. I also want to note, I’ve purposefully made it so both Mac architectures run the unit test, as a precaution. Though, I would like to look into the possibility of running two online unit tests (one on Linux, one on Mac arm64) |
the only way to have two concurrent runners is to have two tokens and two test servers with different channel, bot and event IDs. it would likely be overkill, plus each would need to be limited to one at a time like the Linux unit tests run is. |
Ah right, yeah that's fair enough. |
Timezone has been fixed on the Mac (it appeared to be under PST, it is now under UTC) and the CI has passed. This PR is ready! |
what, don't you know? EVERYONE lives in the USA 😆 |
🤣 |
Downscaled the VM due to it requesting a lot of resources. Will re-run the action to make sure it hasn't slowed down too much. |
Job finished in 3 minutes 48 seconds, even when downscaled! |
This PR changes the ci.yml workflow to now use a matrix for MacOS. This also means we now have a self-hosted Mac runner (using Apple silicone) available!