Skip to content

Commit

Permalink
fix: fix clang c++17 build (#933)
Browse files Browse the repository at this point in the history
  • Loading branch information
Mishura4 authored Oct 9, 2023
1 parent 2d11c8f commit d804820
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 8 deletions.
14 changes: 7 additions & 7 deletions include/dpp/managed.h
Original file line number Diff line number Diff line change
Expand Up @@ -41,44 +41,44 @@ namespace dpp {
/**
* @brief Constructor, initialises id to 0.
*/
constexpr managed() noexcept = default;
managed() = default;

/**
* @brief Constructor, initialises ID
* @param nid ID to set
*/
constexpr managed(const snowflake nid) noexcept : id{nid} {}
managed(const snowflake nid) : id{nid} {}

/**
* @brief Copy constructor
* @param rhs Object to copy
*/
constexpr managed(const managed &rhs) noexcept = default;
managed(const managed &rhs) = default;

/**
* @brief Move constructor
*
* Effectively equivalent to copy constructor
* @param rhs Object to move from
*/
constexpr managed(managed &&rhs) noexcept = default;
managed(managed &&rhs) = default;

/**
* @brief Destroy the managed object
*/
virtual ~managed() noexcept = default;
virtual ~managed() = default;

/**
* @brief Copy assignment operator
* @param rhs Object to copy
*/
constexpr managed &operator=(const managed& rhs) noexcept = default;
managed &operator=(const managed& rhs) = default;

/**
* @brief Move assignment operator
* @param rhs Object to move from
*/
constexpr managed &operator=(managed&& rhs) noexcept = default;
managed &operator=(managed&& rhs) = default;

/**
* @brief Get the creation time of this object according to Discord.
Expand Down
2 changes: 1 addition & 1 deletion include/dpp/snowflake.h
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ class DPP_EXPORT snowflake final {
* @throw dpp::logic_exception on assigning a negative value. The function is noexcept if the type given is unsigned
* @param snowflake_val snowflake value as an integer type
*/
template <typename T, typename = std::enable_if_t<std::is_integral_v<T>>>
template <typename T, typename = std::enable_if_t<std::is_integral_v<T> && !std::is_same_v<T, bool>>>
constexpr snowflake(T snowflake_val) noexcept(std::is_unsigned_v<T>) : value(static_cast<std::make_unsigned_t<T>>(snowflake_val)) {
/**
* we cast to the unsigned version of the type given - this maintains "possible loss of data" warnings for sizeof(T) > sizeof(value)
Expand Down

0 comments on commit d804820

Please sign in to comment.