Skip to content

Commit

Permalink
fix: make modals work again by making to_json_impl and fill_from_json…
Browse files Browse the repository at this point in the history
… virtual
  • Loading branch information
braindigitalis committed Oct 16, 2023
1 parent b37e9ac commit 96654b6
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions include/dpp/appcommand.h
Original file line number Diff line number Diff line change
Expand Up @@ -326,14 +326,14 @@ struct DPP_EXPORT interaction_response : public json_interface<interaction_respo
* @param j JSON to fill from
* @return interaction_response& Reference to self
*/
interaction_response& fill_from_json_impl(nlohmann::json* j);
virtual interaction_response& fill_from_json_impl(nlohmann::json* j);

/**
* @brief Build json for this object
*
* @return json JSON object
*/
json to_json_impl(bool with_id = false) const;
virtual json to_json_impl(bool with_id = false) const;

public:
/**
Expand Down Expand Up @@ -415,15 +415,15 @@ struct DPP_EXPORT interaction_modal_response : public interaction_response, publ
* @param j JSON to fill from
* @return interaction_response& Reference to self
*/
interaction_modal_response& fill_from_json_impl(nlohmann::json* j);
virtual interaction_modal_response& fill_from_json_impl(nlohmann::json* j);

/**
* @brief Build a json for this object
* @param with_id include id in json output
*
* @return json JSON object
*/
json to_json_impl(bool with_id = false) const;
virtual json to_json_impl(bool with_id = false) const;

public:
/**
Expand Down

0 comments on commit 96654b6

Please sign in to comment.