Skip to content

Commit

Permalink
remove deleted ctors which break older clang and g++
Browse files Browse the repository at this point in the history
  • Loading branch information
braindigitalis committed Oct 3, 2024
1 parent 8e99caa commit 89e412e
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 16 deletions.
8 changes: 1 addition & 7 deletions src/dpp/dave/cipher_interface.h
Original file line number Diff line number Diff line change
Expand Up @@ -10,16 +10,10 @@ namespace dpp::dave {
using const_byte_view = array_view<const uint8_t>;
using byte_view = array_view<uint8_t>;

class cipher_interface {
class cipher_interface { // NOLINT
public:
virtual ~cipher_interface() = default;

cipher_interface() = default;
cipher_interface(cipher_interface&&) = delete;
cipher_interface(cipher_interface&) = delete;
cipher_interface operator=(cipher_interface&&) = delete;
cipher_interface operator=(cipher_interface&) = delete;

virtual bool encrypt(byte_view ciphertextBufferOut, const_byte_view plaintextBuffer, const_byte_view nonceBuffer, const_byte_view additionalData, byte_view tagBufferOut) = 0;
virtual bool decrypt(byte_view plaintextBufferOut, const_byte_view ciphertextBuffer, const_byte_view tagBuffer, const_byte_view nonceBuffer, const_byte_view additionalData) = 0;
};
Expand Down
10 changes: 1 addition & 9 deletions src/dpp/dave/openssl_aead_cipher.h
Original file line number Diff line number Diff line change
Expand Up @@ -7,18 +7,10 @@

namespace dpp::dave {

class openssl_aead_cipher : public cipher_interface {
class openssl_aead_cipher : public cipher_interface { // NOLINT
public:
openssl_aead_cipher(const EncryptionKey& encryptionKey);

/**
* Explicitly not copyable
*/
openssl_aead_cipher(openssl_aead_cipher&&) = delete;
openssl_aead_cipher(openssl_aead_cipher&) = delete;
openssl_aead_cipher operator=(openssl_aead_cipher&&) = delete;
openssl_aead_cipher operator=(openssl_aead_cipher&) = delete;

~openssl_aead_cipher() override;

[[nodiscard]] bool inline is_valid() const {
Expand Down

0 comments on commit 89e412e

Please sign in to comment.