ci: remove ctest, it is ass

brainboxdotcc · Dec 18, 2024 · 7e7a0e3 · 7e7a0e3
1 parent 40a2546
commit 7e7a0e3
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -96,7 +96,7 @@ jobs:
 
       - name: Run unit tests
         if: ${{ matrix.cfg.ctest == 'yes' }}
-        run: cd build && ctest -VV
+        run: cd build/library && ./unittest
         env:
           DPP_UNIT_TEST_TOKEN: ${{secrets.DPP_UNIT_TEST_TOKEN}}
           TEST_GUILD_ID: ${{secrets.TEST_GUILD_ID}}
@@ -161,7 +161,7 @@ jobs:
           DONT_RUN_VCPKG: true
 
       - name: Run offline unit tests
-        run: cd build && ctest -VV
+        run: cd build/library && ./unittest
 
   windows: # Windows x64 and x86 build matrix
     permissions:

diff --git a/src/dpp/sslclient.cpp b/src/dpp/sslclient.cpp
@@ -53,9 +53,6 @@
 #include <dpp/cluster.h>
 #include <dpp/dns.h>
 
-/* Maximum allowed time in milliseconds for socket read/write timeouts and connect() */
-constexpr uint16_t SOCKET_OP_TIMEOUT{5000};
-
 namespace dpp {
 
 /**