fix: voiceregion now fills correctly, removed VIP from regions. (#997)

include/dpp/voiceregion.h

@@ -44,14 +44,7 @@ enum voiceregion_flags {
 	/**
 	 * @brief A custom voice region (used for events/etc).
 	 */
-	v_custom = 0x00000100,
-
-	/**
-	 * @brief A VIP voice server.
-	 *
-	 * @warning This is undocumented by Discord and may not even exist anymore.
-	 */
-	v_vip = 0x00001000
+	v_custom = 0x00000100
 };
 
 /**
@@ -123,13 +116,6 @@ class DPP_EXPORT voiceregion : public json_interface<voiceregion> {
 	 * @return true if custom
 	 */
 	bool is_custom() const;
-
-	/**
-	 * @brief True if is a VIP voice server
-	 * 
-	 * @return true if VIP 
-	 */
-	bool is_vip() const;
 };
 
 /**

src/dpp/voiceregion.cpp

@@ -32,20 +32,21 @@ voiceregion::voiceregion() : flags(0)
 }
 
 voiceregion& voiceregion::fill_from_json_impl(nlohmann::json* j) {
-	id = string_not_null(j, "id");
-	name = string_not_null(j, "id");
+	set_string_not_null(j, "id", id);
+	set_string_not_null(j, "name", name);
+
 	if (bool_not_null(j, "optimal")) {
 		flags |= v_optimal;
 	}
+
 	if (bool_not_null(j, "deprecated")) {
 		flags |= v_deprecated;
 	}
+
 	if (bool_not_null(j, "custom")) {
 		flags |= v_custom;
 	}
-	if (bool_not_null(j, "vip")) {
-		flags |= v_vip;
-	}
+
 	return *this;
 }
 
@@ -55,8 +56,7 @@ json voiceregion::to_json_impl(bool with_id) const {
 		{ "name", name },
 		{ "optimal", is_optimal() },
 		{ "deprecated", is_deprecated() },
-		{ "custom", is_custom() },
-		{ "vip", is_vip() }
+		{ "custom", is_custom() }
 	};
 }
 
@@ -72,10 +72,5 @@ bool voiceregion::is_custom() const {
 	return flags & v_custom;
 }
 
-bool voiceregion::is_vip() const {
-	return flags & v_vip;
-}
-
-
 } // namespace dpp