Skip to content

Commit

Permalink
feat: Added file size limit to avatars and banners (#1209)
Browse files Browse the repository at this point in the history
  • Loading branch information
Jaskowicz1 authored Jul 22, 2024
1 parent 4427d09 commit 142e67c
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 0 deletions.
2 changes: 2 additions & 0 deletions include/dpp/user.h
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@

namespace dpp {

constexpr uint32_t MAX_AVATAR_SIZE = 10240 * 1000; // 10240KB.

/**
* @brief Various bitmask flags used to represent information about a dpp::user
*/
Expand Down
9 changes: 9 additions & 0 deletions src/dpp/cluster/user.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,19 @@ void cluster::current_user_edit(const std::string &nickname, const std::string&
};

if (!avatar_blob.empty()) {
if(avatar_blob.size() > MAX_AVATAR_SIZE) { // Avatar limit is 10240 kb.
throw dpp::length_exception(err_icon_size, "Avatar file exceeds discord limit of 10240 kilobytes");
}
j["avatar"] = "data:" + mimetypes.find(avatar_type)->second + ";base64," + base64_encode((unsigned char const*)avatar_blob.data(), static_cast<unsigned int>(avatar_blob.length()));
}

if (!banner_blob.empty()) {
/* There doesn't seem to be a banner limit (probably due to the limit of 640x280)
* however, this is here as a precautionary.
*/
if(banner_blob.size() > MAX_AVATAR_SIZE) {
throw dpp::length_exception(err_icon_size, "Banner file exceeds discord limit of 10240 kilobytes");
}
j["banner"] = "data:" + mimetypes.find(banner_type)->second + ";base64," + base64_encode((unsigned char const*)banner_blob.data(), static_cast<unsigned int>(banner_blob.length()));
}

Expand Down

0 comments on commit 142e67c

Please sign in to comment.