Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix release notes for version updates #1645

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Conversation

samwinebrake
Copy link
Collaborator

The previous tag was not being set correctly when comparing between the previous tag and latest tag to form release notes.

@samwinebrake samwinebrake requested a review from KartikP December 17, 2024 20:30
@samwinebrake
Copy link
Collaborator Author

(see here and here... overlap between pr history)

Copy link
Collaborator

@KartikP KartikP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Cleaner approach

@samwinebrake samwinebrake merged commit db133a0 into master Dec 17, 2024
4 checks passed
@samwinebrake samwinebrake deleted the sw/fix_release_notes branch December 17, 2024 20:49
@samwinebrake samwinebrake restored the sw/fix_release_notes branch December 17, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants