Remove layer map discovery log warning #1476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mike-ferguson
approved these changes
Nov 19, 2024
deirdre-k
approved these changes
Nov 20, 2024
mschrimpf
approved these changes
Nov 20, 2024
| return None | ||
| except Exception as e: | ||
| self._logger.error(f"Error importing model to search for region_layer_map: {e}") |
There was a problem hiding this comment.
how about a debug statement instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we had some logging for when layer mapping could not be loaded. This logging made it seem like there was an actual error rather than a warning/info. See example here: #533 (comment)
Decided to remove the logging entirely to be consistent with previous version of ModelCommitment. I.e., if no region layer map was provided, it would just silently continue the way it was before.
Additionally, local development (i.e., without placing the model in
/models/) also works but the Error makes it seem like it did not. See below: