Coggan benchmark identifiers fix #1370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
retriggering now that benchmarks trigger unit test plugins looks like this no longer retriggers testing correctly. this must be addressed |
|
for now retriggering with blank space |
KartikP
added a commit
that referenced
this pull request
Oct 25, 2024
* Revert "add sam_test_resnet_3 to models (#1309)" (#1310) This reverts commit 85ed01e. * add sam_test_resnet_4 to models (#1313) Co-authored-by: Jenkins <[email protected]> * add mvimgnet_rf to models (#1339) Co-authored-by: Jenkins <[email protected]> * add mvimgnet_ss_00 to models (#1340) Co-authored-by: Jenkins <[email protected]> * add mvimgnet_ss_03 to models (#1342) Co-authored-by: Jenkins <[email protected]> * add mvimgnet_ss_05 to models (#1343) Co-authored-by: Jenkins <[email protected]> * add mvimgnet_ss_03 to models (#1345) Co-authored-by: Jenkins <[email protected]> * add mvimgnet_ms_05 to models (#1346) Co-authored-by: Jenkins <[email protected]> * add mvimgnet_ss_02 to models (#1347) Co-authored-by: Jenkins <[email protected]> * add mvimgnet_ss_04 to models (#1348) Co-authored-by: Jenkins <[email protected]> * Remove brainscore vision from env lock to make env updates easier (#1351) * Coggan benchmark identifiers fix (#1370) * add tong. to identifier * add tong. to benchmark identifiers * Update test.py w/ tong. * Update test.py with tong. * Update __init__.py --------- Co-authored-by: Sam Winebrake <[email protected]> Co-authored-by: Katherine Fairchild <[email protected]> Co-authored-by: Jenkins <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, assertion errors are occurring for the Coggan benchmark because the registry doesn't include
tong.before the identifier. Here is an example of the error:AssertionError: No registrations found for tong.Coggan2024_behavior-ConditionWiseAccuracySimilarity