Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the version_id changes after moving the weight files; fix dependency issues with temporal models #1249

Open
wants to merge 129 commits into
base: master
Choose a base branch
from
Open

Fix the version_id changes after moving the weight files; fix dependency issues with temporal models #1249

wants to merge 129 commits into from

Conversation

YingtianDt
Copy link
Contributor

No description provided.

Yingtian Tang and others added 30 commits February 25, 2024 09:23
feature: support temporal models for neural alignment by chaning Temp…
d97d452 
…oralIgnore to Temporal Aligned
@YingtianDt
Merge branch 'brain-score:master' into master
2a32f46
@YingtianDt
add example temporal submission
c372d12
@YingtianDt
Merge branch 'master' of https://github.com/YingtianDt/brain-score
40d2d2b 
Update to the newest origin main.
@YingtianDt
Merge branch 'brain-score:master' into master
c0827b3
@YingtianDt
complete new framework
92cede9
@YingtianDt
Merge branch 'master' of https://github.com/YingtianDt/brain-score
e74015d 
merge new updates from origin main
@YingtianDt
new module: temporal model helpers
088b9af
@YingtianDt
change the arch of temporal; add tutorials
c5b9097
@YingtianDt
improve: better naming
8f301a3
@YingtianDt
update: wrapper tutorial on brain model
3c3e475
@YingtianDt
add feature: inferencer identifier tracked by extractor for result ca…
34fbc08 
…ching
@YingtianDt
fix: video fps sampling; need more tests!
f6c2fe4
@YingtianDt
fix bugs: video sampling based on fps was wrong.
7e948ed
@YingtianDt
Merge branch 'brain-score:master' into master
3998027
@YingtianDt
add mmaction2 models; add more features to the inferencers
17ecc5d
@YingtianDt
Merge branch 'master' of https://github.com/YingtianDt/brain-score
5fac41c 
merge updates
@YingtianDt
Merge branch 'brain-score:master' into master
20941fe
@YingtianDt
PR: temporal model helpers
89bf58c
@YingtianDt
PR fix: not including gitmodules for now
1433635
@YingtianDt @mschrimpf
Update brainscore_vision/model_helpers/brain_transformation/temporal.py
b678e95 
Co-authored-by: Martin Schrimpf <[email protected]>
@YingtianDt @mschrimpf
Update brainscore_vision/model_helpers/brain_transformation/temporal.py
905c964 
Co-authored-by: Martin Schrimpf <[email protected]>
@YingtianDt @mschrimpf
Update brainscore_vision/model_helpers/brain_transformation/temporal.py
e1e77ca 
Co-authored-by: Martin Schrimpf <[email protected]>
@YingtianDt @mschrimpf
Update brainscore_vision/models/temporal_models/test.py
817b448 
Co-authored-by: Martin Schrimpf <[email protected]>
@YingtianDt
add mae_st; add ding2012
ad8cf5a
@YingtianDt
Merge branch 'master' of https://github.com/YingtianDt/brain-score
749c371 
merge
@YingtianDt
try new arch
95e413e
@YingtianDt
merge
d020363
@YingtianDt
init ding2012
d6960fc
@YingtianDt
add tests for temporal model helpers; add block inferencer
227e801
YingtianDt and others added 20 commits June 18, 2024 09:42
@YingtianDt
Merge branch 'master' of https://github.com/YingtianDt/brain-score
ea732d7
@YingtianDt
Merge branch 'master' into master
96bc38b
@deirdre-k
Merge branch 'master' into master
fab8741
@YingtianDt
Merge branch 'master' into master
c39233b
@YingtianDt
update: naming of failed to pickle func in joblibmapper
91505cb
@YingtianDt
Merge branch 'master' into master
516492a
@YingtianDt
Merge branch 'brain-score:master' into master
f87d9ac
@YingtianDt
add temporal metric helpers
0f8fee4
@YingtianDt
add temporal version of mamjajhong2015
e06853e
@YingtianDt
Merge branch 'master' of https://github.com/YingtianDt/brain-score
b1dcaf7
@mike-ferguson
Merge branch 'master' into master
57ce832
@YingtianDt
Merge branch 'master' into master
e7dd0ef
@YingtianDt
Update benchmark.py
f0243a0 
type hint
@YingtianDt
Update benchmark.py
5542996
@YingtianDt @mschrimpf
Update brainscore_vision/metric_helpers/temporal.py
149a6b0 
Co-authored-by: Martin Schrimpf <[email protected]>
@YingtianDt @mschrimpf
Update brainscore_vision/metrics/internal_consistency/__init__.py
9cdebde 
Co-authored-by: Martin Schrimpf <[email protected]>
@YingtianDt
Update benchmark.py
790851b
@YingtianDt
Merge branch 'brain-score:master' into master
afe5c54
@YingtianDt
fix: version_id after file moving; missing dependency
e09eb5d
@YingtianDt
Merge branch 'brain-score:master' into master
cdd445f
@mike-ferguson
Copy link
Member

@YingtianDt thanks! Our PR testing is right in the middle of being ported to AWS, so thanks for hanging in there while we sort all of the bugs out.

@kvfairchild kvfairchild added the OOM When unit tests run out of memory label Oct 1, 2024
@YingtianDt
Copy link
Contributor Author

I believe this PR is ready to be merged. @mschrimpf

@KartikP
Copy link
Collaborator

KartikP commented Oct 2, 2024

@YingtianDt Your PR has a couple of issues. Some of them arise from a saturation of disk space for the tests (on AWS execution tests), which we will increase for you. But it appears temporal_model_mmaction2 is failing your plugin-specific tests (on the legacy unit test plugins).

@mschrimpf All generic tests have failed. Is this because this is just a "different class" of models. Should anything be changed in terms of how unittest_plugins is run?

@mschrimpf
Copy link
Member

All generic tests have failed. Is this because this is just a "different class" of models. Should anything be changed in terms of how unittest_plugins is run?

The models should still pass on the generic tests. @YingtianDt any ideas why these seem to fail?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
OOM When unit tests run out of memory
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@YingtianDt @mike-ferguson @KartikP @mschrimpf @kvfairchild @deirdre-k