Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update environment_lock.yml w/ new brainio name #1235

Merged
merged 2 commits into from
Sep 30, 2024

Conversation

samwinebrake
Copy link
Collaborator

updating name of brainio to brainscore-brainio in order to appease pypi naming

Copy link
Collaborator

@KartikP KartikP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once tests pass

@mike-ferguson
Copy link
Member

Retriever default test

@KartikP
Copy link
Collaborator

KartikP commented Sep 25, 2024

@samwinebrake What needs to be done for this?

@samwinebrake samwinebrake merged commit e42fb79 into master Sep 30, 2024
10 of 12 checks passed
@samwinebrake samwinebrake deleted the sw/update_env_lock branch September 30, 2024 13:05
KartikP added a commit that referenced this pull request Sep 30, 2024
* Update score_new_plugins.yml to use actions/upload-artifact@v4 (#1283)

Current workflow uses v2. This has been causing an automatic failure in scoring jobs.

v3 is being deprecated in 2 months.

Based on `Breaking Changes` as seen on the actions readme, this should work with a simple replacement of the version number.

* Update environment_lock.yml w/ new brainio name (#1235)

* Update environment_lock.yml w/ new brainio name

* update env lock w/ pypi packages

---------

Co-authored-by: Sam Winebrake <[email protected]>
KartikP added a commit that referenced this pull request Sep 30, 2024
* Update score_new_plugins.yml to use actions/upload-artifact@v4 (#1283)

Current workflow uses v2. This has been causing an automatic failure in scoring jobs.

v3 is being deprecated in 2 months.

Based on `Breaking Changes` as seen on the actions readme, this should work with a simple replacement of the version number.

* Update environment_lock.yml w/ new brainio name (#1235)

* Update environment_lock.yml w/ new brainio name

* update env lock w/ pypi packages

* Revert "add resnet50_11ad3fa6 to models (#1282)" (#1286)

This reverts commit 55de4cd.

---------

Co-authored-by: Sam Winebrake <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants