Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coggan behavioral benchmark extension #1213

Draft
wants to merge 45 commits into
base: master
Choose a base branch
from

Conversation

benlonnqvist
Copy link
Contributor

@benlonnqvist benlonnqvist commented Sep 4, 2024

This PR extends the Coggan behavioral benchmark by adding the labeling task to the Coggan benchmark.

TODOs:

  • ImageNet-map Coggan task labels and add to brain_transformation/behavior
  • Add labeling benchmarks for Coggan
  • add engineering benchmark for Coggan
  • verify / unify metric use across benchmarks to standard brain-score metric format
  • make condition-wise accuracy distance metric (@ddcoggan)
  • clean up data handling in __call__
  • general cleanup of unneeded imports etc.
  • optimize accuracydistance over conditions
  • add group ceiling
  • add chance level adjustment
  • check test scores

@benlonnqvist benlonnqvist marked this pull request as draft September 4, 2024 15:35
@kvfairchild kvfairchild added the OOM When unit tests run out of memory label Sep 30, 2024
@KartikP KartikP removed the OOM When unit tests run out of memory label Sep 30, 2024
@KartikP KartikP closed this Sep 30, 2024
@KartikP KartikP reopened this Sep 30, 2024
@KartikP
Copy link
Collaborator

KartikP commented Sep 30, 2024

@benlonnqvist My apologies for closing and reopening your PR. We noticed that the unit test was running out of memory. This should fix it.

@KartikP KartikP closed this Sep 30, 2024
@KartikP KartikP reopened this Sep 30, 2024
@kvfairchild kvfairchild added the OOM When unit tests run out of memory label Sep 30, 2024
@benlonnqvist
Copy link
Contributor Author

Thanks @KartikP, this PR is still in draft status and at least some tests will definitely not pass because the PR is not complete. While I'm not sure why that might cause the OOM issues, it's certainly possible. When the PR is in a state where I think the tests should (barring bugs) pass, I'll mark as ready for review!

@KartikP
Copy link
Collaborator

KartikP commented Oct 1, 2024

That sounds great with me!

As to why your PR is causing OOM issues, it is because changes to model_helpers triggers generic tests in a subset of predefined models (seen here). One particular model (resnext101_32x8d_wsl) seems to be the issue. We'll have this dealt with over the next few days.

@benlonnqvist
Copy link
Contributor Author

Oh, right. I remember now, I had that with another PR some time ago as well. Let me know if you want me to slice the model_helpers label changes to another PR, but either way is fine either way. Happy to wait a bit as well if a fix is on the horizon.

@benlonnqvist
Copy link
Contributor Author

Hi @KartikP, it seems that the PR is still running into an OOM error. Is there any timeline on when it might be fixed? Thanks again!

@benlonnqvist benlonnqvist reopened this Oct 29, 2024
@KartikP KartikP closed this Oct 29, 2024
@KartikP KartikP reopened this Oct 29, 2024
@KartikP KartikP closed this Oct 29, 2024
@KartikP KartikP reopened this Oct 29, 2024
@KartikP KartikP removed the OOM When unit tests run out of memory label Oct 29, 2024
@KartikP KartikP closed this Oct 29, 2024
@KartikP KartikP reopened this Oct 29, 2024
@KartikP KartikP closed this Oct 29, 2024
@KartikP KartikP reopened this Oct 29, 2024
@benlonnqvist benlonnqvist reopened this Nov 6, 2024
@benlonnqvist benlonnqvist marked this pull request as draft November 19, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants