Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pathfinder benchmark #1193

Merged
merged 21 commits into from
Sep 26, 2024
Merged

Conversation

benlonnqvist
Copy link
Contributor

@benlonnqvist benlonnqvist commented Aug 21, 2024

This PR adds the Lonnqvist2024 pathfinder benchmark.

TODOs:

  • push stimulus set & assembly to s3
  • add tests

@benlonnqvist benlonnqvist marked this pull request as draft August 22, 2024 11:41
@benlonnqvist benlonnqvist reopened this Sep 3, 2024
@benlonnqvist benlonnqvist marked this pull request as ready for review September 4, 2024 08:29
@benlonnqvist
Copy link
Contributor Author

@mschrimpf I'm not sure what the default tester is but it's failing because brainio is not found - otherwise, looks good.

@KartikP
Copy link
Collaborator

KartikP commented Sep 26, 2024

@benlonnqvist The legacy unittests (Brain-Score Jenkins CI -plugin tests and Brain-Score Jenkins CI) are being deprecated very soon. We have yet to change the Branch Protection Rules to no longer require those unittests. I can bypass the branch protection rules for you.

@KartikP KartikP merged commit 615e6b9 into brain-score:master Sep 26, 2024
10 of 13 checks passed
KartikP added a commit that referenced this pull request Sep 26, 2024
* point to pypi instead of git (#1236)

* update dependency names w/ hyphens (#1238)

* point to pypi instead of git

* Update pyproject.toml with hyphens

* Custom trained scaling models (#1206)

* Custom trained models

* Fix missing library

* Fix a missing library

* Not every model needs timm

* Trigger build tests

* Use model_id instead of model_name to ensure correct weights are loaded

* timm is missing from deit models

* timm is missing from deit models

* Fix requirements.txt newline

* Package models into a single plugin

* Update requirements.txt

* Update requirements.txt

* Update requirements.txt

* Change the order of models

* Update model.py

* Disable resultcaching for vits

* Tests reordering

* Revert tests back

* Update model.py

* Update model.py

* Update to sync workflow (#1248)

* Update to sync workflow

Adds dynamic PR title and commit history included in PR description.

Adds `No changes detected` job.

* Update no_changes condition and text

Refined condition to not require PR_merge because that is when this condition SHOULD be triggered to indicate the correct status of the workflow.

* enable unverified SSL for scaling models (#1263)

* Add pathfinder benchmark (#1193)

* add pathfinder task

* update data packaging

* modify benchmark file

* add benchmark tests

* upload datasets

* add some tests and fix some bugs

* add dataset tests

* fix errors with plugin imports

* add error with stimulus set naming test

* fix bug with field name test

* remove field from test that shouldn't be there

* fix model loading bug in test

* fix ceiled test value -> raw test value

---------

Co-authored-by: Martin Schrimpf <[email protected]>

---------

Co-authored-by: Sam Winebrake <[email protected]>
Co-authored-by: Abdulkadir Gokce <[email protected]>
Co-authored-by: Ben Lonnqvist <[email protected]>
Co-authored-by: Martin Schrimpf <[email protected]>
KartikP added a commit that referenced this pull request Sep 26, 2024
* point to pypi instead of git (#1236)

* update dependency names w/ hyphens (#1238)

* point to pypi instead of git

* Update pyproject.toml with hyphens

* Custom trained scaling models (#1206)

* Custom trained models

* Fix missing library

* Fix a missing library

* Not every model needs timm

* Trigger build tests

* Use model_id instead of model_name to ensure correct weights are loaded

* timm is missing from deit models

* timm is missing from deit models

* Fix requirements.txt newline

* Package models into a single plugin

* Update requirements.txt

* Update requirements.txt

* Update requirements.txt

* Change the order of models

* Update model.py

* Disable resultcaching for vits

* Tests reordering

* Revert tests back

* Update model.py

* Update model.py

* Update to sync workflow (#1248)

* Update to sync workflow

Adds dynamic PR title and commit history included in PR description.

Adds `No changes detected` job.

* Update no_changes condition and text

Refined condition to not require PR_merge because that is when this condition SHOULD be triggered to indicate the correct status of the workflow.

* enable unverified SSL for scaling models (#1263)

* Add pathfinder benchmark (#1193)

* add pathfinder task

* update data packaging

* modify benchmark file

* add benchmark tests

* upload datasets

* add some tests and fix some bugs

* add dataset tests

* fix errors with plugin imports

* add error with stimulus set naming test

* fix bug with field name test

* remove field from test that shouldn't be there

* fix model loading bug in test

* fix ceiled test value -> raw test value

---------

Co-authored-by: Martin Schrimpf <[email protected]>

* Ep/add fixres resnext101 32x48d wsl (#1103)

* Add model

* Modify test

* Fix imports

---------

Co-authored-by: Ethan Pellegrini <[email protected]>
Co-authored-by: Kartik Pradeepan <[email protected]>

---------

Co-authored-by: Sam Winebrake <[email protected]>
Co-authored-by: Abdulkadir Gokce <[email protected]>
Co-authored-by: Ben Lonnqvist <[email protected]>
Co-authored-by: Martin Schrimpf <[email protected]>
Co-authored-by: pellegreene <[email protected]>
Co-authored-by: Ethan Pellegrini <[email protected]>
KartikP added a commit that referenced this pull request Sep 26, 2024
* point to pypi instead of git (#1236)

* update dependency names w/ hyphens (#1238)

* point to pypi instead of git

* Update pyproject.toml with hyphens

* Custom trained scaling models (#1206)

* Custom trained models

* Fix missing library

* Fix a missing library

* Not every model needs timm

* Trigger build tests

* Use model_id instead of model_name to ensure correct weights are loaded

* timm is missing from deit models

* timm is missing from deit models

* Fix requirements.txt newline

* Package models into a single plugin

* Update requirements.txt

* Update requirements.txt

* Update requirements.txt

* Change the order of models

* Update model.py

* Disable resultcaching for vits

* Tests reordering

* Revert tests back

* Update model.py

* Update model.py

* Update to sync workflow (#1248)

* Update to sync workflow

Adds dynamic PR title and commit history included in PR description.

Adds `No changes detected` job.

* Update no_changes condition and text

Refined condition to not require PR_merge because that is when this condition SHOULD be triggered to indicate the correct status of the workflow.

* enable unverified SSL for scaling models (#1263)

* Add pathfinder benchmark (#1193)

* add pathfinder task

* update data packaging

* modify benchmark file

* add benchmark tests

* upload datasets

* add some tests and fix some bugs

* add dataset tests

* fix errors with plugin imports

* add error with stimulus set naming test

* fix bug with field name test

* remove field from test that shouldn't be there

* fix model loading bug in test

* fix ceiled test value -> raw test value

---------

Co-authored-by: Martin Schrimpf <[email protected]>

* Ep/add fixres resnext101 32x48d wsl (#1103)

* Add model

* Modify test

* Fix imports

---------

Co-authored-by: Ethan Pellegrini <[email protected]>
Co-authored-by: Kartik Pradeepan <[email protected]>

* Ep/add inception v4 (#1099)

* Add inception_v4

* Update model.py

* Update model.py

* Fix layer mapping

* Fix imports

---------

Co-authored-by: Ethan Pellegrini <[email protected]>

---------

Co-authored-by: Sam Winebrake <[email protected]>
Co-authored-by: Abdulkadir Gokce <[email protected]>
Co-authored-by: Ben Lonnqvist <[email protected]>
Co-authored-by: Martin Schrimpf <[email protected]>
Co-authored-by: pellegreene <[email protected]>
Co-authored-by: Ethan Pellegrini <[email protected]>
KartikP added a commit that referenced this pull request Sep 28, 2024
* point to pypi instead of git (#1236)

* update dependency names w/ hyphens (#1238)

* point to pypi instead of git

* Update pyproject.toml with hyphens

* Custom trained scaling models (#1206)

* Custom trained models

* Fix missing library

* Fix a missing library

* Not every model needs timm

* Trigger build tests

* Use model_id instead of model_name to ensure correct weights are loaded

* timm is missing from deit models

* timm is missing from deit models

* Fix requirements.txt newline

* Package models into a single plugin

* Update requirements.txt

* Update requirements.txt

* Update requirements.txt

* Change the order of models

* Update model.py

* Disable resultcaching for vits

* Tests reordering

* Revert tests back

* Update model.py

* Update model.py

* Update to sync workflow (#1248)

* Update to sync workflow

Adds dynamic PR title and commit history included in PR description.

Adds `No changes detected` job.

* Update no_changes condition and text

Refined condition to not require PR_merge because that is when this condition SHOULD be triggered to indicate the correct status of the workflow.

* enable unverified SSL for scaling models (#1263)

* Add pathfinder benchmark (#1193)

* add pathfinder task

* update data packaging

* modify benchmark file

* add benchmark tests

* upload datasets

* add some tests and fix some bugs

* add dataset tests

* fix errors with plugin imports

* add error with stimulus set naming test

* fix bug with field name test

* remove field from test that shouldn't be there

* fix model loading bug in test

* fix ceiled test value -> raw test value

---------

Co-authored-by: Martin Schrimpf <[email protected]>

* Ep/add fixres resnext101 32x48d wsl (#1103)

* Add model

* Modify test

* Fix imports

---------

Co-authored-by: Ethan Pellegrini <[email protected]>
Co-authored-by: Kartik Pradeepan <[email protected]>

* Ep/add inception v4 (#1099)

* Add inception_v4

* Update model.py

* Update model.py

* Fix layer mapping

* Fix imports

---------

Co-authored-by: Ethan Pellegrini <[email protected]>

* Fixed pip install git (#1280)

---------

Co-authored-by: Sam Winebrake <[email protected]>
Co-authored-by: Abdulkadir Gokce <[email protected]>
Co-authored-by: Ben Lonnqvist <[email protected]>
Co-authored-by: Martin Schrimpf <[email protected]>
Co-authored-by: pellegreene <[email protected]>
Co-authored-by: Ethan Pellegrini <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants