Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#305 add number sign before each number in lessons #314

Merged
merged 5 commits into from
Oct 31, 2021
Merged

#305 add number sign before each number in lessons #314

merged 5 commits into from
Oct 31, 2021

Conversation

zuevval
Copy link
Member

@zuevval zuevval commented Sep 3, 2021

Closes #305

@zuevval zuevval added bug Something isn't working lessons Lessons section improvement labels Sep 3, 2021
@zuevval zuevval added this to the 1.2.2 or 1.3.0 milestone Sep 3, 2021
@zuevval zuevval linked an issue Sep 3, 2021 that may be closed by this pull request
Put a number sign in front of each number or digit #305
Closed
2 tasks
@zuevval
Copy link
Member Author

zuevval commented Sep 3, 2021

I will ask VN and check the changed course, then mark this request as ready

@zuevval zuevval force-pushed the feature/305-number-sign-everywhere branch from 9af4ea2 to 6c1d637 Compare September 3, 2021 13:32
winter-yuki
winter-yuki requested changes Sep 3, 2021
View reviewed changes
Copy link
Member

@winter-yuki winter-yuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a mistake

app/src/main/java/com/github/braillesystems/learnbraille/res/GolubinaCourse.kt Outdated Show resolved Hide resolved
app/src/main/java/com/github/braillesystems/learnbraille/res/_DSL.kt Show resolved Hide resolved
@zuevval zuevval force-pushed the feature/305-number-sign-everywhere branch from 1768db6 to 2d218ca Compare September 4, 2021 09:08
@zuevval
Copy link
Member Author

zuevval commented Sep 6, 2021

VN suggested to mention somewhere that in practice we do not put number signs for technical reasons. I would like to mention this in lessons and in the practice help.

@zuevval zuevval marked this pull request as ready for review October 30, 2021 11:32
@zuevval zuevval requested a review from winter-yuki October 30, 2021 11:33
@zuevval zuevval mentioned this pull request Oct 30, 2021
Merged
winter-yuki
winter-yuki approved these changes Oct 30, 2021
View reviewed changes
Copy link
Member

@winter-yuki winter-yuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to annotate all the number signs and provide the possibility to hide them

app/src/main/java/com/github/braillesystems/learnbraille/res/GolubinaCourse.kt Show resolved Hide resolved
@zuevval zuevval mentioned this pull request Oct 31, 2021
Open
@zuevval
Copy link
Member Author

zuevval commented Oct 31, 2021

I'd like to annotate all the number signs and provide the possibility to hide them

VN would mind. She is for the compulsion to put number signs. Logged your proposal in #257

@zuevval zuevval merged commit e939fed into dev Oct 31, 2021
@zuevval zuevval deleted the feature/305-number-sign-everywhere branch October 31, 2021 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winter-yuki winter-yuki winter-yuki approved these changes

Assignees
No one assigned
Labels
bug Something isn't working lessons Lessons section improvement
Projects
None yet
Milestone
1.2.2 or 1.3.0
Development

Successfully merging this pull request may close these issues.

Put a number sign in front of each number or digit
2 participants
@zuevval @winter-yuki