Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor #259

Merged
merged 18 commits into from
Sep 26, 2020
Merged

Refactor #259

merged 18 commits into from
Sep 26, 2020

Conversation

winter-yuki
Copy link
Member

@winter-yuki winter-yuki commented Sep 24, 2020

Closes #258
Closes #196

Depends on #252

@winter-yuki winter-yuki added this to the 1.2.0 milestone Sep 25, 2020
@winter-yuki winter-yuki marked this pull request as ready for review September 26, 2020 16:15
@winter-yuki winter-yuki requested a review from zuevval September 26, 2020 16:15
Copy link
Member

@zuevval zuevval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've checked and tested. It's OK

private lateinit var context: Context

@Before
fun before() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note for the future: repetitions here may have been reduced by using parametrized tests

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am I right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, thank you

@zuevval zuevval merged commit 51b622c into dev Sep 26, 2020
@winter-yuki winter-yuki deleted the refactor branch September 26, 2020 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants