Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: simplified eslint.config #439

Closed

Conversation

JoshuaKGoldberg
Copy link

@JoshuaKGoldberg JoshuaKGoldberg commented Dec 12, 2024

Applies a bunch of simplifications to the file. I've commented them inline. The biggest one is using ts(eslint).config to get types and flatten arrays.

Please forgive me if you already know a bunch of the comments 😅. I figured they'd be useful in case anybody is reading this.

I'm also not sure I'm not removing some rules that actually are intentional. Definitely not suggesting this should be 100% trusted!

💖

Copy link

vercel bot commented Dec 12, 2024

@JoshuaKGoldberg is attempting to deploy a commit to the Brad Garropy's projects Team on Vercel.

A member of the Team first needs to authorize it.

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review December 12, 2024 22:17
Copy link

vercel bot commented Dec 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
bradgarropy ✅ Ready (Inspect) Visit Preview Dec 13, 2024 3:22am

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (eslint@cd090e0). Learn more about missing BASE report.

Additional details and impacted files
@@            Coverage Diff             @@
##             eslint      #439   +/-   ##
==========================================
  Coverage          ?   100.00%           
==========================================
  Files             ?       165           
  Lines             ?      4706           
  Branches          ?       152           
==========================================
  Hits              ?      4706           
  Misses            ?         0           
  Partials          ?         0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bradgarropy
Copy link
Owner

@all-contributors add @JoshuaKGoldberg for review and tool

Copy link
Contributor

@bradgarropy

I've put up a pull request to add @JoshuaKGoldberg! 🎉

@bradgarropy
Copy link
Owner

I took all of your suggestions into account, and here's what I ended up with, so clean!

https://github.com/bradgarropy/bradgarropy.com/blob/eslint/eslint.config.js

Thank you for all of your help, I added you as a contributor!

@JoshuaKGoldberg
Copy link
Author

🙌 awesome!

@JoshuaKGoldberg JoshuaKGoldberg deleted the eslint-with-love branch December 13, 2024 19:39
bradgarropy added a commit that referenced this pull request Dec 13, 2024
Adds @JoshuaKGoldberg as a contributor for review, tool.

This was requested by bradgarropy [in this
comment](#439 (comment))

---------

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Co-authored-by: Brad Garropy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants