Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added ability to change mac address #149

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

MohamedA95
Copy link

Hello, thanks for this great library.
I added ability to change station mac address both temporary and permanently.
Best regards.

@JAndrassy
Copy link

JAndrassy commented Jul 22, 2018

look at the differences. many unnecessary differences with spaces and removed folder from includes and one new function has set and other Set. the temporary flag could be a parameter of the function

@MohamedA95
Copy link
Author

hmm, this is weird I will fix it. nice idea I will do it.
thanks a lot.

@MohamedA95
Copy link
Author

hi, i have a question
In file src/utility/EspDrv.cpp it includes two files
#include "utility/EspDrv.h"
#include "utility/debug.h"
those files are in the same directory, why do we need to do "utility/EspDrv.h" not only "utility/EspDrv.h" is they are in the same directory ?
Best regards.

@JAndrassy
Copy link

JAndrassy commented Jul 27, 2018

the folder structure of the arduino libraries has some strange rules and they change over time. these includes were written this way already in original WiFi library. Bruno didn't change it, so leave it this way.

@MohamedA95
Copy link
Author

oh ok, if it is working then no problem. regarding the spaces that are deleted and added, i do not what is causing this. I am using Atom could it be the cause ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants