Restore canvas focus on properties panel focus change #1094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows components to hook into the properties panel focus state.
This ensures our standard editing behavior is preserved, i.e. when destructive properties panel operations force blur.
This ensure properties panel focus is not lost when I mouse down on, i.e. a label. On the other hand this remains unfocusable through keyboard navigation. We can consider to change that some day, just not today 😉.
This was referenced Nov 20, 2024
nikku
requested changes
Nov 20, 2024
bpmn-io-tasks
bot
added
in progress
|
After some more discussion with Nico, we decided that this is not needed. Restoring focus on the canvas covers an edge case, but doesn't make UX any more predictable. If user interacts with the properties panel, they should expect the focus to now be in the panel and not on the canvas. This PR is getting parked in the backlog until we decide to redesign UX around panel focus or there is some feedback from users. There is another PR implementing the minimal change to make properties panel container focusable: #1095 |
jarekdanielak
added
backlog
bpmn-io-tasks
bot
added
in progress
|
CC @lmbateman on the UX discussion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Related to https://github.com/bpmn-io/internal-docs/issues/1081
Original pull request #1093
This is a better solution to keep the canvas focused when user is only briefly interacting with properties panel, without focusing any input fields.
Original pull request was dropped due to reasons explain in this comment.
Screen.Recording.2024-11-20.at.12.53.56.mov
Checklist
To ensure you provided everything we need to look at your PR:
@bpmn-io/srtoolCloses {LINK_TO_ISSUE}orRelated to {LINK_TO_ISSUE}