Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support zeebe:userTask #1026

Merged
merged 6 commits into from
Feb 29, 2024
Merged

Support zeebe:userTask #1026

merged 6 commits into from
Feb 29, 2024

Conversation

barmac
Copy link
Member

@barmac barmac commented Feb 20, 2024

@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Feb 20, 2024
@barmac barmac changed the title Allow to set zeebe user task Support zeebe:userTask Feb 20, 2024
@barmac barmac force-pushed the allow-to-set-zeebe-user-task branch from 35c3917 to 022f027 Compare February 21, 2024 15:52
@barmac
Copy link
Member Author

barmac commented Feb 26, 2024

The external reference field should be FEEL-optional

@barmac barmac marked this pull request as ready for review February 26, 2024 10:47
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Feb 26, 2024
@barmac barmac requested review from a team, philippfromme, marstamm and nikku and removed request for a team February 26, 2024 10:47
@barmac
Copy link
Member Author

barmac commented Feb 26, 2024

Ready for review.

@barmac
Copy link
Member Author

barmac commented Feb 27, 2024

So apparently this is now failing on CI due to some changes in the behaviors module.

@barmac
Copy link
Member Author

barmac commented Feb 27, 2024 •
edited
Loading

In 468b1ec, I am removing the tests which caused CI to fail. We don't want to remove output parameters via "propagateChildVariables" switch anymore.

@barmac barmac force-pushed the allow-to-set-zeebe-user-task branch from 0540c55 to 468b1ec Compare February 27, 2024 17:06
@nikku
Copy link
Member

nikku commented Feb 28, 2024 •
edited
Loading

To consider: Change implementation which is duplicated consistently to Type:

image

⬇️

Type for these kinds of choices is already a mentioned term.

image

nikku
nikku approved these changes Feb 28, 2024
View reviewed changes
Copy link
Member

@nikku nikku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm. I like how we retain the existing context where appropriate, too.

Consider one feedback (remove double implement) as a potential follow-up.

@barmac
Copy link
Member Author

barmac commented Feb 29, 2024

I updated the label and will be merging this shortly.

@barmac barmac merged commit 4b89bc9 into main Feb 29, 2024
8 checks passed
@barmac barmac deleted the allow-to-set-zeebe-user-task branch February 29, 2024 08:33
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikku nikku nikku approved these changes

@philippfromme philippfromme Awaiting requested review from philippfromme philippfromme was automatically assigned from bpmn-io/modeling-dev

@marstamm marstamm Awaiting requested review from marstamm marstamm was automatically assigned from bpmn-io/modeling-dev

Assignees

@barmac barmac

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@barmac @nikku