Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix intermittent error when deleting programs #354

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

anfredette
Copy link
Contributor

Change the order of operations in handleProgDelete() to update the status before removing the finalizer when a *Program is being deleted.

Fixes: #353

Copy link

codecov bot commented Dec 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@9b4813d). Learn more about missing BASE report.
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
controllers/bpfman-agent/common.go 0.00% 11 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #354   +/-   ##
=======================================
  Coverage        ?   28.12%           
=======================================
  Files           ?      128           
  Lines           ?    11207           
  Branches        ?        0           
=======================================
  Hits            ?     3152           
  Misses          ?     7773           
  Partials        ?      282           
Flag Coverage Δ
unittests 28.12% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Billy99 Billy99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@mergify mergify bot merged commit 48d744b into bpfman:main Jan 2, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BpfPrograms are sometimes deleted before bpfman agent can make the final status update
2 participants