WIP: Initial pass at BpfApplication CRD update for load/attach split #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anfredette
force-pushed
the
load-attach-split
branch
2 times, most recently
from
e352df4 to
0531a5f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #347 +/- ##
==========================================
- Coverage 27.66% 27.16% -0.51%
==========================================
Files 87 87
Lines 7503 7746 +243
==========================================
+ Hits 2076 2104 +28
- Misses 5227 5433 +206
- Partials 200 209 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
anfredette
force-pushed
the
load-attach-split
branch
2 times, most recently
from
113089c to
60d0115
Compare
|
All of the examples will need to be updated with the new CRD format before the Kubernetes integration tests will pass. |
|
@anfredette, this pull request is now in conflict and requires a rebase. |
The main change is that a separate optional list of attach points is included with each program (except for fentry and fexit programs that just include an attach boolean). Otherwise, the info is all the same. The list of attach points may be updated any time after the programs are loaded, which allows the program to be loaded before any attachments are made, and allows attachments to be added after the program has been loaded. Existing controllers have been updated to work with new CRDs, but they only work with a single attach point per program. I've updated the bpfman.io_v1alpha1_bpfapplication.yaml, but the others still have the old format and won't work with the current code. TODO: Add a per-node CRD (BpfProgram analog) to maintain the per-node state for the BpfApplication. Signed-off-by: Andre Fredette <[email protected]>
This is currently incomplete. Signed-off-by: Andre Fredette <[email protected]>
anfredette
force-pushed
the
load-attach-split
branch
from
083793b to
5dce708
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main change is that a separate optional list of attach points is
included with each program (except for fentry and fexit programs that just
include an
attachboolean). Otherwise, the info is all the same.The list of attach points may be updated any time after the programs
are loaded, which allows the program to be loaded before any attachments are
made, and allows attachments to be added after the program has been loaded.
Existing controllers have been updated to work with new CRDs, but they only
work with a single attach point per program.
I've updated the bpfman.io_v1alpha1_bpfapplication.yaml, but the others still have
the old format and won't work with the current code.
TODO: Add a per-node CRD (BpfProgram analog) to maintain the per-node
state for the BpfApplication.