Chef workstation and Use Omnitruck API to get Chef URLs #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arizvisa
added
the
enhancement
|
@daxgames, I know this is a pretty old PR, but this _is_ adding functionality (i.e. adding more provisioners), right? Like, rather, are we presently provisioning with chef incorrectly? Sorry, I'm not too familiar with chef and so I want to make sure I prioritize this PR correctly if you're still interested in merging it after all this time. |
cleanup ignore *.*.* ignore *.*.* cleanup README.md cleanup cleanup cleanup cleanup add chef workstation fixes
daxgames
force-pushed
the
chef_workstation
branch
from
4ccb0a5
to
357a5db
Compare
arizvisa
added a commit
to arizvisa/boxcutter-windows
that referenced
this pull request
Jan 6, 2020
…oner. Revert "Applied changes in .gitignore from daxgames/boxcutter_windows@357a5db for updating the Chef provisioner." This reverts commit b9c1098.
|
I split up your single commit into distinctly separate commits and re-factored its logic a bit. I'ma close this PR as it will be superseded by PR #200 once I'm done testing it. I'll post the status of its merging here tho once its done in case you're still interested in using it. |
arizvisa
added
the
PR Superseded
arizvisa
added a commit
that referenced
this pull request
Jan 6, 2020
Revert "Applied changes in .gitignore from daxgames/boxcutter_windows@357a5db for updating the Chef provisioner." This reverts commit b9c1098.
|
Ok. This was merged as PR #200. Thanks! |
daxgames
pushed a commit
to daxgames/boxcutter_windows
that referenced
this pull request
Feb 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Omnitruck API to get Chef URLs
Add Chef Workstation as a CM parameter
Additional filename patterns in .gitignore.