Addtl certs #30
Merged
Addtl certs #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 18, 2021 18:30
We want to support the case where an intermediate was rotated or newly created but still establishes trust back to the root in the signed layout.
mikhailswift
commented
Feb 19, 2021
| os.Exit(1) | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
This whole bit should probably be in it's own function but I think we need to look at how we're loading keys and certs in the bigger picture.
|
Looks great! |
mikhailswift
added a commit
that referenced
this pull request
Aug 20, 2021
* Mark necessary flags as required for run and verify commands * Allow intermediates to be supplied at verification time We want to support the case where an intermediate was rotated or newly created but still establishes trust back to the root in the signed layout.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #24 by allowing extra intermediates to be passed at verification
Piling on the tech debt -- this code could be improved, and perhaps I'll spend some time over the weekend doing so. But it works in my testing. I signed
certs/demo.layoutwithtest/data/aliceafter replacing the layout'srootcaswith a newly generated one frommake leaf_certs. I removed the intermediates from the layout, and then ranmake test-run.Afterward I ran
./bin/in-toto verify -i ./certs/example.com.intermediate.cert.pem -k ./test/data/alice.pub -l ./root.layoutand it verified successfully. I re-tried with./bin/in-toto verify -k ./test/data/alice.pub -l ./root.layout, excluding the intermediate, and it failed as expected.I made some modifications to the cmd to ensure expected flags were required, as well.
This needs tests.