fix: Move Documents load time and emit meaningful content timestamp #1460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstoffan
reviewed
Jul 28, 2022
| this.emitLogEvent(PREVIEW_METRIC, { | ||
| encoding, | ||
| event_name: LOAD_METRIC.previewLoadEvent, | ||
| value: previewLoadTime.elapsed || 0, | ||
| [LOAD_METRIC.fileInfoTime]: infoTime.elapsed || 0, | ||
| [LOAD_METRIC.convertTime]: convertTime.elapsed || 0, | ||
| [LOAD_METRIC.downloadResponseTime]: downloadTime.elapsed || 0, | ||
| [LOAD_METRIC.contentLoadTime]: contentLoadTime.elapsed || 0, | ||
| [LOAD_METRIC.contentLoadTime]: contentLoadTimeDuration || 0, | ||
| [LOAD_METRIC.meaningfulContentTimestamp]: meaningfulContentTimestamp, |
There was a problem hiding this comment.
Should this be contentLoadTimestamp to stay consistent with its other attribute? Should it default to 0, as well?
| @@ -1174,11 +1172,6 @@ class DocBaseViewer extends BaseViewer { | |||
| // Broadcast that preview has 'loaded' when page structure is available | |||
| if (!this.loaded) { | |||
| this.loaded = true; | |||
| this.emit(VIEWER_EVENT.load, { | |||
There was a problem hiding this comment.
Will this affect our existing metrics?
|
Conrad Chan seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved the
loadevent emitted fromDocBaseViewerfrompagesinitto the firstpagerenderedevent for PDFJS.Also modified the
emitLoadMetrics()method inPreview.jsto include ameaningful_content_timestampwhich can be used to calculate Time to Meaningful Content (TTMC)